Summary: | Clean up checkout notes template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize, nick, pierre-marc.thibault, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/circ/checkout-notes.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 20654 | ||
Attachments: |
Bug 21693: Clean up checkout notes template
Bug 21693: Clean up checkout notes template Bug 21693: Clean up checkout notes template Bug 21693: Clean up checkout notes template Bug 21693: Make page title consistent with other pages Bug 21693: Clean up checkout notes template Bug 21693: Make page title consistent with other pages |
Description
Owen Leonard
2018-10-26 16:37:20 UTC
Created attachment 81320 [details] [review] Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. Created attachment 81321 [details] [review] Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. Created attachment 81339 [details] [review] Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Created attachment 81363 [details] [review] Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 81364 [details] [review] Bug 21693: Make page title consistent with other pages For some reason we use 'Home' in the bread crumbs, but 'Koha' as starting point in the page title. Changed to make consistent with other pages in Circulation. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Before this patch the 'Mark seen' and 'Mark not seen' buttons work. I can't make them work with this Created attachment 82226 [details] [review] Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 82227 [details] [review] Bug 21693: Make page title consistent with other pages For some reason we use 'Home' in the bread crumbs, but 'Koha' as starting point in the page title. Changed to make consistent with other pages in Circulation. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Nick Clemens from comment #6) > Before this patch the 'Mark seen' and 'Mark not seen' buttons work. I can't > make them work with this This was an error in the placement of the <form> tag. That's the only change to the signed-off patch. I hope it's okay to return this to 'Passed QA.' (In reply to Owen Leonard from comment #9) > (In reply to Nick Clemens from comment #6) > > Before this patch the 'Mark seen' and 'Mark not seen' buttons work. I can't > > make them work with this > > This was an error in the placement of the <form> tag. That's the only change > to the signed-off patch. I hope it's okay to return this to 'Passed QA.' Yup,that's okay, would be better as a follow-up patch so that the change can be easily seen and verified, but it works in testing Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series. |