| Summary: | Add the Koha::Account->lines method | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | josef.moravec, martin.renvoize, nick, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 13098 | ||
| Bug Blocks: | 21681, 21696 | ||
| Attachments: |
Bug 21694: Add the Koha::Account->lines method
Bug 21694: Keep the context Bug 21694: Add the Koha::Account->lines method Bug 21694: Keep the context Bug 21694: Add the Koha::Account->lines method Bug 21694: Keep the context |
||
|
Description
Jonathan Druart
2018-10-26 18:02:54 UTC
Created attachment 81323 [details] [review] Bug 21694: Add the Koha::Account->lines method Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 81324 [details] [review] Bug 21694: Keep the context Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 81357 [details] [review] Bug 21694: Add the Koha::Account->lines method Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 81358 [details] [review] Bug 21694: Keep the context Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Could you rebase please? Sorry, but it does not apply on top of master + bug 13098 I am still getting fatal: sha1 information is lacking or useless (Koha/Account.pm). I can't replicate the sha1 issue I'm afraid.. Created attachment 81637 [details] [review] Bug 21694: Add the Koha::Account->lines method Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 81638 [details] [review] Bug 21694: Keep the context Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> I was not able to apply it on top of bug 13098, but on top of bug 13098 + bug 21673 it applies, setting back to Passed QA Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported for now to 18.05.x series. |