| Summary: | Clean up access files template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | josef.moravec, martin.renvoize, nick, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/admin/access_files.pl | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 11317 | ||
| Bug Blocks: | 20654 | ||
| Attachments: |
Bug 21695: Clean up access files template
Bug 21695: Clean up access files template Bug 21695: Clean up access files template |
||
|
Description
Owen Leonard
2018-10-26 18:35:51 UTC
Created attachment 81334 [details] [review] Bug 21695: Clean up access files template This patch modifies the access files template to help compliance with several coding guidelines: - Bootstrap grid - Improve DataTables configuration - Move date formatting from the script to the template - Markup corrections To test you must modify koha-conf.xml to contain something like the following: <access_dirs> <access_dir>/tmp/koha-public</access_dir> </access_dirs> Make sure the directory exists and contains multiple files. - Go to Tools -> Access files - Confirm that the page looks correct and the layout adjusts at various browser widths. - Confirm that DataTables functionality works correctly, including correct sorting by date. Created attachment 81536 [details] [review] Bug 21695: Clean up access files template This patch modifies the access files template to help compliance with several coding guidelines: - Bootstrap grid - Improve DataTables configuration - Move date formatting from the script to the template - Markup corrections To test you must modify koha-conf.xml to contain something like the following: <access_dirs> <access_dir>/tmp/koha-public</access_dir> </access_dirs> Make sure the directory exists and contains multiple files. - Go to Tools -> Access files - Confirm that the page looks correct and the layout adjusts at various browser widths. - Confirm that DataTables functionality works correctly, including correct sorting by date. Created attachment 82176 [details] [review] Bug 21695: Clean up access files template This patch modifies the access files template to help compliance with several coding guidelines: - Bootstrap grid - Improve DataTables configuration - Move date formatting from the script to the template - Markup corrections To test you must modify koha-conf.xml to contain something like the following: <access_dirs> <access_dir>/tmp/koha-public</access_dir> </access_dirs> Make sure the directory exists and contains multiple files. - Go to Tools -> Access files - Confirm that the page looks correct and the layout adjusts at various browser widths. - Confirm that DataTables functionality works correctly, including correct sorting by date. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series. |