Bug 21696

Summary: Use Koha::Account->lines from Koha::Account
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: martin.renvoize, nick, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 21673, 21681, 21694    
Bug Blocks:    
Attachments: Bug 21696: Use Koha::Account->lines from Koha::Account
Bug 21696: Use Koha::Account->lines from Koha::Account
Bug 21696: Use Koha::Account->lines from Koha::Account

Description Jonathan Druart 2018-10-26 18:49:54 UTC

    
Comment 1 Jonathan Druart 2018-10-26 18:52:01 UTC
Created attachment 81332 [details] [review]
Bug 21696: Use Koha::Account->lines from Koha::Account

There is now Koha::Account->lines, we should use it instead of
Koha::Account::Lines->search
Comment 2 Martin Renvoize (ashimema) 2018-10-26 18:57:52 UTC
Created attachment 81333 [details] [review]
Bug 21696: Use Koha::Account->lines from Koha::Account

There is now Koha::Account->lines, we should use it instead of
Koha::Account::Lines->search

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2018-10-26 18:58:51 UTC
No brainer, works as expected :)

Signing Off
Comment 4 Tomás Cohen Arazi (tcohen) 2018-10-27 11:50:22 UTC
Created attachment 81359 [details] [review]
Bug 21696: Use Koha::Account->lines from Koha::Account

There is now Koha::Account->lines, we should use it instead of
Koha::Account::Lines->search

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Nick Clemens (kidclamp) 2018-11-06 17:57:16 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize (ashimema) 2018-11-16 12:36:22 UTC
Enhancement, will not be backported to 18.05.x series.