| Summary: | FIX POD of cancel_unfilled_holds.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> | 
| Component: | Command-line Utilities | Assignee: | Magnus Enger <magnus> | 
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> | 
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, josef.moravec, martin.renvoize, nick, robin | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | Bug 21698 - FIX POD of cancel_unfilled_holds.pl Bug 21698 - FIX POD of cancel_unfilled_holds.pl Bug 21698: Fix POD of cancel_unfilled_holds.pl Bug 21698: (QA follow-up) Fix typo verbosev -> verbose | ||
| 
        
          Description
        
        
          Magnus Enger
        
        
        
        
          2018-10-26 19:59:31 UTC
        
       Created attachment 81340 [details] [review] Bug 21698 - FIX POD of cancel_unfilled_holds.pl To test: - Run "perldoc misc/cronjobs/holds/cancel_unfilled_holds.pl" - Notice some problems: -- No description in the NAME section -- Descriptions of options in the SYNOPSIS section -- A literal head1 -- Long options are listed with a single leading dash -- Options --verbose and --confirm are not listed under OPTIONS) - Take a look at the script itself to see that --verbose and --confirm should be listed. - Also note the typo on line 97: 'v|verbosev' => \$verbose, - Apply the patch - Look at the script and perldoc again and check that all problems described above are now fixed. Created attachment 81499 [details] [review] Bug 21698 - FIX POD of cancel_unfilled_holds.pl To test: - Run "perldoc misc/cronjobs/holds/cancel_unfilled_holds.pl" - Notice some problems: -- No description in the NAME section -- Descriptions of options in the SYNOPSIS section -- A literal head1 -- Long options are listed with a single leading dash -- Options --verbose and --confirm are not listed under OPTIONS) - Take a look at the script itself to see that --verbose and --confirm should be listed. - Also note the typo on line 97: 'v|verbosev' => \$verbose, - Apply the patch - Look at the script and perldoc again and check that all problems described above are now fixed. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Created attachment 81534 [details] [review] Bug 21698: Fix POD of cancel_unfilled_holds.pl To test: - Run "perldoc misc/cronjobs/holds/cancel_unfilled_holds.pl" - Notice some problems: -- No description in the NAME section -- Descriptions of options in the SYNOPSIS section -- A literal head1 -- Long options are listed with a single leading dash -- Options --verbose and --confirm are not listed under OPTIONS) - Take a look at the script itself to see that --verbose and --confirm should be listed. - Also note the typo on line 97: 'v|verbosev' => \$verbose, - Apply the patch - Look at the script and perldoc again and check that all problems described above are now fixed. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 81535 [details] [review] Bug 21698: (QA follow-up) Fix typo verbosev -> verbose Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 - I always like POD improvements. Pushed to 17.11.x for 17.11.13 18720 |