Summary: | Adding 'edititems' user-permission | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Authentication | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | colin.campbell, dpavlin, nengard, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
functional example of both 'editcatalogue' and 'edititems' user-perms
functional example of 'editcatalogue' user-perm only functional example of 'edititems' user-perm only 1) example of 'edititems' user-perm with independent-branches 2) example of 'edititems' user-perm with independent-branches Follow-up patch with template revisions Revised fix Follow-up fix |
Description
Chris Cormack
2010-05-21 00:47:23 UTC
This feature is now working in HEAD, although I see that there are still places in the template which do not respect the setting: Links to "edit items" which should be missing or disabled when the user lacks that permission. Created attachment 2413 [details] [review] Follow-up patch with template revisions This patch follows up on the addition of the 'edititems' permission by adding a check of the new permission to places in the interface which link to the edit item screen. The catalogue toolbar had to be extensively re-worked in order to ensure that the "New" and "Edit" menus would appear (or not) whether or not edit_catalogue, edit_items, or create_subscription permissions are on. Original patch will probably not apply cleanly anymore. A revised version of this fix can be found here: http://gitorious.org/koha-dev/koha-dev/commits/ps-Bug-2170-eddititems-permission-markup-2010-07-23 Created attachment 2837 [details] [review] Revised fix Revised for current HEAD. Signed off Owen's revised patch. Also sent a patch adding the permission check to another location where edit items can be called Patches pushed, please test This bug is mentioned in: Updated fix for Bug 2170, Adding 'edititems' user-permission http://lists.koha-community.org/pipermail/koha-patches/2010-December/013247.html Updated fix for Bug 2170, Adding 'edititems' user-permission http://lists.koha-community.org/pipermail/koha-patches/2010-December/013249.html Bug 2170 Supplementary Fix Wrap link in permissions check http://lists.koha-community.org/pipermail/koha-patches/2010-December/013250.html I see something that needs a correction: If a user has 'editcatalogue" permission but not 'edititems' permission they should not be offered the option on addbiblio.pl to 'Save and edit items.' The default should be 'Save and view record.' Created attachment 3126 [details] [review] Follow-up fix Save button and duplicate confirmation redirects must respect the edititems permission: Users without permission to edit items should not be redirected to the edit items screen. On testing this patch I found the following: I logged in as a staff member with editcatalog permissions but not edititems and when i clicked save when editing a bib record it said I didn't have permission and logged me out. I think it should have brought me to the edited bib record. Also - less major - a whitespace error: .dotest/patch:31: space before tab in indent. background : #FFF none; warning: 1 line adds whitespace errors. Nicole, you signed off on the patch, but you have some comments, is it worth pushing it, or should I wait til the rest is addressed? Owen and I talked on IRC and found that I didn't really have a problem - so that's why I signed off :) No need to wait. Pushed, please test and mark resolved |