Summary: | Remove $shib in Auth.t (17776 folllow-up) | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Authentication | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED WONTFIX | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dpavlin, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 17776 | ||
Bug Blocks: | |||
Attachments: | Bug 21711: Remove $shib in Auth.t (17776 folllow-up) |
Description
Marcel de Rooy
2018-10-29 12:43:03 UTC
Created attachment 81484 [details] [review] Bug 21711: Remove $shib in Auth.t (17776 folllow-up) See patch (QA follow-up) Remove shibboleth package variables on bug 17776. The variable is no longer global and should be removed in Auth.t. Trivial. Resolves warning: Name "C4::Auth::shib" used only once: possible typo at t/db_dependent/Auth.t line 298. Test plan: Run t/db_dependent/Auth.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Moving into PQA directly (could be considered as a trivial QA follow-up for 17776). No more results from git grep -E "::shib" btw after this. I don't get any instances in grep before this patch? (In reply to Nick Clemens from comment #4) > I don't get any instances in grep before this patch? Ah. This is foolish. It came from a patch set that is not pushed yet.. |