Summary: | Ease translation of account and account offset type descriptions | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Templates | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | josef.moravec, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 21584 | ||
Bug Blocks: | |||
Attachments: |
Bug 21715: Ease translation of account and account offset type descriptions
Bug 21715: Ease translation of account and account offset type descriptions Bug 21715: Ease translation of account and account offset type descriptions Bug 21715: Ease translation of account and account offset type descriptions |
Description
Tomás Cohen Arazi (tcohen)
2018-10-29 15:12:44 UTC
Created attachment 81519 [details] [review] Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type! Created attachment 81524 [details] [review] Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type! Created attachment 81544 [details] [review] Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type! Signed-off-by: Josef Moravec <josef.moravec@gmail.com> btw, we should get rigt of the "thanks" :) Created attachment 81651 [details] [review] Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type! Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I guess you could argue which is easier. At the moment it's easy to make a typo, but you have all strings together in one entry which gives you context. With this patch they will all appear separately and out of order. What I wanted to say too: But it follows an existing pattern and will be less error-prone. Awesome work all! Pushed to master for 18.11 Causation not in 18.05.x series. |