Bug 21715

Summary: Ease translation of account and account offset type descriptions
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: TemplatesAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: josef.moravec, katrin.fischer, martin.renvoize, nick
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 21584    
Bug Blocks:    
Attachments: Bug 21715: Ease translation of account and account offset type descriptions
Bug 21715: Ease translation of account and account offset type descriptions
Bug 21715: Ease translation of account and account offset type descriptions
Bug 21715: Ease translation of account and account offset type descriptions

Description Tomás Cohen Arazi 2018-10-29 15:12:44 UTC
Both are now on separate files and descriptions are not enclosed by <span> tags, making it more error prone on the translation step.
Comment 1 Tomás Cohen Arazi 2018-10-29 15:18:50 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2018-10-29 15:38:49 UTC
Created attachment 81524 [details] [review]
Bug 21715: Ease translation of account and account offset type descriptions

This patch moves accounts-related descriptions into a single file to
ease finding them, and also encloses descriptions inside <span> tags to
make it easier to translate.

To test:
- Apply this patch
- Verify the templates work as expected
=> SUCCESS: No behaviour change
- Sign off :-D

Bonus: there were two cases in which the INCLUDE line used 'accountline'
as parameter, making it fail to pick the right account type!
Comment 3 Josef Moravec 2018-10-29 20:40:19 UTC
Created attachment 81544 [details] [review]
Bug 21715: Ease translation of account and account offset type descriptions

This patch moves accounts-related descriptions into a single file to
ease finding them, and also encloses descriptions inside <span> tags to
make it easier to translate.

To test:
- Apply this patch
- Verify the templates work as expected
=> SUCCESS: No behaviour change
- Sign off :-D

Bonus: there were two cases in which the INCLUDE line used 'accountline'
as parameter, making it fail to pick the right account type!

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Katrin Fischer 2018-10-31 07:15:08 UTC
btw, we should get rigt of the "thanks" :)
Comment 5 Katrin Fischer 2018-10-31 07:15:57 UTC
Created attachment 81651 [details] [review]
Bug 21715: Ease translation of account and account offset type descriptions

This patch moves accounts-related descriptions into a single file to
ease finding them, and also encloses descriptions inside <span> tags to
make it easier to translate.

To test:
- Apply this patch
- Verify the templates work as expected
=> SUCCESS: No behaviour change
- Sign off :-D

Bonus: there were two cases in which the INCLUDE line used 'accountline'
as parameter, making it fail to pick the right account type!

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2018-10-31 07:16:43 UTC
I guess you could argue which is easier. At the moment it's easy to make a typo, but you have all strings together in one entry which gives you context. With this patch they will all appear separately and out of order.
Comment 7 Katrin Fischer 2018-10-31 07:17:30 UTC
What I wanted to say too: But it follows an existing pattern and will be less error-prone.
Comment 8 Nick Clemens 2018-11-08 02:27:59 UTC
Awesome work all!

Pushed to master for 18.11
Comment 9 Martin Renvoize 2018-11-16 13:01:34 UTC
Causation not in 18.05.x series.