Description
Tomás Cohen Arazi
2018-10-31 14:49:06 UTC
Created attachment 81733 [details] [review] Bug 21740: Show @ when editing fixed-length fields on bibliographic frameworks This is a consistency issue: we store '@' as the subfield for fixed-lenght fields, yet on editing '_' is displayed (on the form and the tab). This was probably done to avoid URI encoding problems in the past. This patch restores the '@' everywhere. To test: - Open the MARC structure for any bibliographic MARC framework - Choose Actions > Subfields on any fixed-length field => ERROR: Notice the tab has an underscore (_) and the subfield code is '_' as well. - Cancel => SUCCESS: '@' is displayed on the list - Apply this patch - Restart all the things: $ restart_all - Choose Actions > Subfields on any fixed-length field => SUCCESS: '@' is displayed in the tab title, and on the 'Subfield code' form field. - Save some changes => SUCCESS: Things work correctly. - Sign off :-D Created attachment 81920 [details] [review] Bug 21740: Show @ when editing fixed-length fields on bibliographic frameworks This is a consistency issue: we store '@' as the subfield for fixed-lenght fields, yet on editing '_' is displayed (on the form and the tab). This was probably done to avoid URI encoding problems in the past. This patch restores the '@' everywhere. To test: - Open the MARC structure for any bibliographic MARC framework - Choose Actions > Subfields on any fixed-length field => ERROR: Notice the tab has an underscore (_) and the subfield code is '_' as well. - Cancel => SUCCESS: '@' is displayed on the list - Apply this patch - Restart all the things: $ restart_all - Choose Actions > Subfields on any fixed-length field => SUCCESS: '@' is displayed in the tab title, and on the 'Subfield code' form field. - Save some changes => SUCCESS: Things work correctly. - Sign off :-D Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Created attachment 81923 [details] [review] Bug 21740: Show @ when editing fixed-length fields on bibliographic frameworks This is a consistency issue: we store '@' as the subfield for fixed-lenght fields, yet on editing '_' is displayed (on the form and the tab). This was probably done to avoid URI encoding problems in the past. This patch restores the '@' everywhere. To test: - Open the MARC structure for any bibliographic MARC framework - Choose Actions > Subfields on any fixed-length field => ERROR: Notice the tab has an underscore (_) and the subfield code is '_' as well. - Cancel => SUCCESS: '@' is displayed on the list - Apply this patch - Restart all the things: $ restart_all - Choose Actions > Subfields on any fixed-length field => SUCCESS: '@' is displayed in the tab title, and on the 'Subfield code' form field. - Save some changes => SUCCESS: Things work correctly. - Sign off :-D Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Created attachment 81925 [details] [review] Bug 21740: Show @ when editing fixed-length fields on bibliographic frameworks This is a consistency issue: we store '@' as the subfield for fixed-lenght fields, yet on editing '_' is displayed (on the form and the tab). This was probably done to avoid URI encoding problems in the past. This patch restores the '@' everywhere. To test: - Open the MARC structure for any bibliographic MARC framework - Choose Actions > Subfields on any fixed-length field => ERROR: Notice the tab has an underscore (_) and the subfield code is '_' as well. - Cancel => SUCCESS: '@' is displayed on the list - Apply this patch - Restart all the things: $ restart_all - Choose Actions > Subfields on any fixed-length field => SUCCESS: '@' is displayed in the tab title, and on the 'Subfield code' form field. - Save some changes => SUCCESS: Things work correctly. - Sign off :-D Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 18.11 Created attachment 81979 [details] [review] Bug 21740: (QA follow-up) Make tests aware of special hrefs Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Moved the follow-up patch into its own bug (Bug 21770) Created attachment 82232 [details] [review] Bug 21749: Add tests for ImportFramework Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 82233 [details] [review] Bug 21749: Fix import of CSV biblio framework Bug 9701 added 2 new columns to the table marc_tag_structure which broke the import of biblio frameworks if the CSV file was generated with a previous version. Test plan: - Export a biblio framework from 17.11 - Import it into 18.05+ Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to 18.05.x for 18.05.06 Pushed to 17.11.x for 17.11.13 This looks like a very old strange behavior. Thanks @all ;) |