| Summary: | Checkin of withdrawn items marked successful via SIP2 when BlockReturnOfWithdrawnItems is enabled | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | SIP2 | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | colin.campbell, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 21745: Checkin of withdrawn items marked successful via SIP2 when BlockReturnOfWithdrawnItems is enabled
Bug 21745: Checkin of withdrawn items marked successful via SIP2 when BlockReturnOfWithdrawnItems is enabled |
||
Some more details: C4/SIP/ILS/Transaction/Checkin.pm does set a 'CV' field to 99 if the item is withdrawn - this doesn't cause a screen message, or set the 'ok' flag to 0 C4/SIP/ILS.pm does not check the CV for 99, or check the value of 'BlockReturnOfLostItems' Created attachment 82364 [details] [review] Bug 21745: Checkin of withdrawn items marked successful via SIP2 when BlockReturnOfWithdrawnItems is enabled If an item is marked withdrawn, and the syspref BlockReturnOfWithdrawnItems is enabled, checking in a withdrawn items will fail but not be indicated by the SIP response. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Created attachment 82366 [details] [review] Bug 21745: Checkin of withdrawn items marked successful via SIP2 when BlockReturnOfWithdrawnItems is enabled The intention in the code is unclear. we copy all of messages to error_messages, but only ever are interested in one value in it. Then in ILS do the weird unexplained test that this is the only message. Its unclear whats going on here, and that what the case is. I dont think this is maintainable code. Could we set a flag rather than flinging a hashref around and set it using clearer criteria? |
To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin