Description
Tomás Cohen Arazi (tcohen)
2018-11-01 15:06:00 UTC
Created attachment 82224 [details] [review] Bug 21749: Add tests for ImportFramework Created attachment 82225 [details] [review] Bug 21749: Fix import of CSV biblio framework Bug 9701 added 2 new columns to the table marc_tag_structure which broke the import of biblio frameworks if the CSV file was generated with a previous version. Test plan: - Export a biblio framework from 17.11 - Import it into 18.05+ Created attachment 82234 [details] [review] Bug 21749: Add tests for ImportFramework Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> https://bugs.koha-community.org/show_bug.cgi?id=21740 Created attachment 82235 [details] [review] Bug 21749: Fix import of CSV biblio framework Bug 9701 added 2 new columns to the table marc_tag_structure which broke the import of biblio frameworks if the CSV file was generated with a previous version. Test plan: - Export a biblio framework from 17.11 - Import it into 18.05+ Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> https://bugs.koha-community.org/show_bug.cgi?id=21740 Created attachment 82236 [details] [review] Bug 21749: (QA follow-up) Add more tests for ImportFramework Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> https://bugs.koha-community.org/show_bug.cgi?id=21740 Created attachment 82240 [details] [review] Bug 21749: Add tests for ImportFramework Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 82241 [details] [review] Bug 21749: Fix import of CSV biblio framework Bug 9701 added 2 new columns to the table marc_tag_structure which broke the import of biblio frameworks if the CSV file was generated with a previous version. Test plan: - Export a biblio framework from 17.11 - Import it into 18.05+ Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> https://bugs.koha-community.org/show_bug.cgi?id=21740 Created attachment 82242 [details] [review] Bug 21749: (QA follow-up) Add more tests for ImportFramework This patch adds tests for: - Output of ImportFramework on fields removal and error conditions (file not found) - Different file format behaviour (csv, xml and ods are tested). To test: - Run $ kshell k$ prove t/db_dependent/ImportExportFramework.t => SUCCESS: All green :-D - Sign off :-D Note: the biblio_framework* files are based on the original one on the patchset, and exported in 17.11 with different formats. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 82338 [details] [review] Bug 21749: Add tests for ImportFramework Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 82339 [details] [review] Bug 21749: Fix import of CSV biblio framework Bug 9701 added 2 new columns to the table marc_tag_structure which broke the import of biblio frameworks if the CSV file was generated with a previous version. Test plan: - Export a biblio framework from 17.11 - Import it into 18.05+ Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> https://bugs.koha-community.org/show_bug.cgi?id=21740 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 82340 [details] [review] Bug 21749: (QA follow-up) Add more tests for ImportFramework This patch adds tests for: - Output of ImportFramework on fields removal and error conditions (file not found) - Different file format behaviour (csv, xml and ods are tested). To test: - Run $ kshell k$ prove t/db_dependent/ImportExportFramework.t => SUCCESS: All green :-D - Sign off :-D Note: the biblio_framework* files are based on the original one on the patchset, and exported in 17.11 with different formats. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 Depends on Bug 9701 not in 17.11.x |