Description
Alex Buckley
2018-11-01 21:26:28 UTC
Created attachment 81854 [details] [review] Bug 21754: Automatically clean up outstanding transfers on lost items This is an alternative to bug 21732 as transfers are automatically cancelled on marking an item lost, and the items holding rbanch is set to the transfers source ('from') branch. When an item is marked as lost, the routine should also clean up any outstanding transfers. Also added tests to t/db_dependent/Circulation.t which check: * If transfer is automatically deleted when item is marked as lost * If the items holdingbranch automatically changes when item with transfers on it is marked as lost. Test plan: 1. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 2. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 3. Notice that the transfer is now cancelled for the item and the items holdingbranch is the transfers source ('from') branch 4. Run t/db_dependent/Circulation.t Sponsored-By: Brimbank Library, Australia We sought additional feedback on the mailing lists and currently, the feedback (https://lists.katipo.co.nz/public/koha/2018-November/051788.html) is that this version of the bug is preferable to the original bug 21732, as such I'm going to mark that one as a duplicate and close it so we can move forward with this preferred approach. I'll try to find someone to signoff today so I can proceed with QA. *** Bug 21732 has been marked as a duplicate of this bug. *** Created attachment 82016 [details] [review] Bug 21754: Automatically clean up outstanding transfers on lost items This is an alternative to bug 21732 as transfers are automatically cancelled on marking an item lost, and the items holding rbanch is set to the transfers source ('from') branch. When an item is marked as lost, the routine should also clean up any outstanding transfers. Also added tests to t/db_dependent/Circulation.t which check: * If transfer is automatically deleted when item is marked as lost * If the items holdingbranch automatically changes when item with transfers on it is marked as lost. Test plan: 1. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 2. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 3. Notice that the transfer is now cancelled for the item and the items holdingbranch is the transfers source ('from') branch 4. Run t/db_dependent/Circulation.t Sponsored-By: Brimbank Library, Australia Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Created attachment 82017 [details] [review] Bug 21754: Automatically clean up outstanding transfers on lost items This is an alternative to bug 21732 as transfers are automatically cancelled on marking an item lost, and the items holding rbanch is set to the transfers source ('from') branch. When an item is marked as lost, the routine should also clean up any outstanding transfers. Also added tests to t/db_dependent/Circulation.t which check: * If transfer is automatically deleted when item is marked as lost * If the items holdingbranch automatically changes when item with transfers on it is marked as lost. Test plan: 1. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 2. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 3. Notice that the transfer is now cancelled for the item and the items holdingbranch is the transfers source ('from') branch 4. Run t/db_dependent/Circulation.t Sponsored-by: Brimbank Library, Australia Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> (fixed the introduction of a whitespace line and removed a double declare warning from the new tests as part of QA) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Great work Alex, thank you for all the perseverance. No regressions found, Passing QA. As this is still waiting to be pushed and now conflicts upon being applied I am attaching a rebased patch with the only change being I have changed the number of tests in t/db_dependent/Circulation.pl from 120 to 123. Created attachment 83061 [details] [review] Bug 21754: Automatically clean up outstanding transfers on lost items This is an alternative to bug 21732 as transfers are automatically cancelled on marking an item lost, and the items holding rbanch is set to the transfers source ('from') branch. When an item is marked as lost, the routine should also clean up any outstanding transfers. Also added tests to t/db_dependent/Circulation.t which check: * If transfer is automatically deleted when item is marked as lost * If the items holdingbranch automatically changes when item with transfers on it is marked as lost. Test plan: 1. Find a item which is in transfer, i.e. find an item with the text in the 'Status' field of the table in detail.pl that indicates it is in transfer 2. Set the item to 'Lost' either by clicking on Edit->Edit items from the detail.pl page OR clicking on the Items tab on the left side of the detail.pl page 3. Notice that the transfer is now cancelled for the item and the items holdingbranch is the transfers source ('from') branch 4. Run t/db_dependent/Circulation.t Sponsored-by: Brimbank Library, Australia Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> (fixed the introduction of a whitespace line and removed a double declare warning from the new tests as part of QA) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I am not sure if you need to re-test, if you do then confirming the patch applies cleanly and the t/db_dependent/Circulation.t passes after applying the patch would be the only necessary things to test. Awesome work all! Pushed to master for 19.05 Enhancement will not be backported to 18.11.x series |