Summary: | Default sounds broken in 18.05 - wrong filter/link | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Staff interface | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle, martin.renvoize |
Version: | 18.05 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 21775 | ||
Bug Blocks: | |||
Attachments: |
Bug 21766: Correct filtering on AUDIO_ALERT_PATH js
Bug 21766: Correct filtering on AUDIO_ALERT_PATH js Bug 20996: (RM follow-up) Fix the api tests Bug 21766: Correct filtering on AUDIO_ALERT_PATH js |
Description
Nick Clemens (kidclamp)
2018-11-05 16:10:56 UTC
Created attachment 81972 [details] [review] Bug 21766: Correct filtering on AUDIO_ALERT_PATH js I managed to introduce a bad filter whilst backporting bug 15734 to the 18.05.x series. This patch attempts to correct that. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 81973 [details] [review] Bug 21766: Correct filtering on AUDIO_ALERT_PATH js I managed to introduce a bad filter whilst backporting bug 15734 to the 18.05.x series. This patch attempts to correct that. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 81995 [details] [review] Bug 20996: (RM follow-up) Fix the api tests Created attachment 82003 [details] [review] Bug 21766: Correct filtering on AUDIO_ALERT_PATH js I managed to introduce a bad filter whilst backporting bug 15734 to the 18.05.x series. This patch attempts to correct that. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Martin please include the tests from bug 21775 when you will push this fix. Pushed to 18.05.x for 18.05.06 |