Summary: | Password recovery is broken (see 20023) | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | OPAC | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | cslone, fridolin.somers, m.de.rooy, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 20023 | ||
Bug Blocks: | |||
Attachments: |
Bug 21771: (Follow-up) Revert the shift statement
Bug 21771: (Follow-up) Revert the shift statement |
Description
Katrin Fischer
2018-11-06 13:39:08 UTC
Created attachment 81986 [details] [review] Bug 21771: (Follow-up) Revert the shift statement Obviously you should never shift an items from an array if you need that item later on :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested with entering userid as well as entering email.. Moving to PQA directly Attention RM and Rmaints : This patch is a fix of the last follow-up on 20023. I'll run a test with 17.11.11 as I was just working on this immediately. Created attachment 81987 [details] [review] Bug 21771: (Follow-up) Revert the shift statement Obviously you should never shift an items from an array if you need that item later on :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested with entering userid as well as entering email.. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> (In reply to Katrin Fischer from comment #5) > Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Thanks. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 Pushed to 17.11.x for 17.11.12 |