Bug 21775

Summary: Lack of tests for audio alerts
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, julian.maurice, katrin.fischer, martin.renvoize, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 21766, 21777, 21956    
Attachments: Bug 21775: Add selenium tests for audio alerts
Bug 21775: [18.05.x] Add selenium tests for audio alerts
Bug 21775: Add selenium tests for audio alerts
Bug 21775: Logout before trying to login

Description Jonathan Druart 2018-11-06 18:15:40 UTC
This code is not reliable, we faced too many regressions.

We need a Selenium test to cover it and prevent future regressions
Comment 1 Jonathan Druart 2018-11-06 18:19:03 UTC
Created attachment 82001 [details] [review]
Bug 21775: Add selenium tests for audio alerts

To prevent future regressions
Comment 2 Jonathan Druart 2018-11-06 18:19:59 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2018-11-06 18:20:50 UTC
Attached to its own bug report to make it part of master.

Initially written for bug 21766.
Comment 4 Jonathan Druart 2018-11-06 18:21:43 UTC
Created attachment 82002 [details] [review]
Bug 21775: [18.05.x] Add selenium tests for audio alerts

To prevent future regressions
Comment 5 Julian Maurice 2018-11-09 13:19:15 UTC
Created attachment 82164 [details] [review]
Bug 21775: Add selenium tests for audio alerts

To prevent future regressions

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 6 Tomás Cohen Arazi 2018-11-12 19:30:17 UTC
Pushed for 18.11. Thanks all!
Comment 7 Jonathan Druart 2018-11-12 20:09:22 UTC
Created attachment 82249 [details] [review]
Bug 21775: Logout before trying to login
Comment 8 Jonathan Druart 2018-11-12 20:10:04 UTC
The last patch should fix the jenkins failure:
koha_1       | 
koha_1       |     #   Failed test at t/db_dependent/selenium/regressions.t line 106.
koha_1       |     #                   'Koha staff client'
koha_1       |     #     doesn't match '(?^u:Log in to Koha)'

We must logout before auth.
Comment 9 Tomás Cohen Arazi 2018-11-12 20:37:30 UTC
Follow-up pushed to master. Thanks for the quick reponse, Jonathan.
Martin: beware :-D
Comment 10 Martin Renvoize 2018-11-16 14:17:46 UTC
Pushed to 18.05.x for 18.05.06
Comment 11 Fridolin Somers 2018-11-28 10:08:59 UTC
I prefer not to push to 17.11.x