Bug 21783

Summary: Reindent admin/columns_settings.tt
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: enhancement    
Priority: P5 - low CC: josef.moravec, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.05.00
Attachments: Bug 21783: Reindent admin/columns_settings.tt
Bug 21783: Reindent admin/columns_settings.tt
Bug 21783: Reindent admin/columns_settings.tt
Bug 21783: Reindent admin/columns_settings.tt

Description Owen Leonard 2018-11-07 17:16:05 UTC
admin/columns_settings.tt was created with two-space indentation, but coding guidelines require 4. This patch will reindent the template.
Comment 1 Owen Leonard 2018-11-07 19:15:53 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2019-03-20 13:03:47 UTC Comment hidden (obsolete)
Comment 3 Hayley Pelham 2019-04-17 21:35:28 UTC Comment hidden (obsolete)
Comment 4 Josef Moravec 2019-04-18 11:27:51 UTC
Created attachment 88288 [details] [review]
Bug 21783: Reindent admin/columns_settings.tt

This patch reindents admin/columns_settings.tt to use four spaces
instead of two for indentation, following coding guidelines.

To test, apply the patch and compare the file to master using the -w
flag to ignore whitespace. The only changes should appear where lines
were added during indentation.

Go to Admin -> Columns settings and confirm that everything works
correctly.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 5 Nick Clemens 2019-04-19 14:54:22 UTC
Awesome work all!

Pushed to master for 19.05
Comment 6 Martin Renvoize 2019-04-26 14:37:38 UTC
Enhancement will not be backported to 18.11.x series.