Summary: | Clean up js_includes.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 21784: Clean up js_includes.inc
Bug 21784: Clean up js_includes.inc Bug 21784: Clean up js_includes.inc |
Description
Owen Leonard
2018-11-07 18:54:26 UTC
Created attachment 82044 [details] [review] Bug 21784: Clean up js_includes.inc This patch cleans up js_includes.inc by removing script "type" attributes which are now invalid HTML. The patch also removes "CDATA" markers from script blocks. They have been unnecessary since we stopped using an XHTML doctype. To test, apply the patch and look at various pages in the staff client to confirm that no JavaScript-driven interactions are broken. Created attachment 88528 [details] [review] Bug 21784: Clean up js_includes.inc This patch cleans up js_includes.inc by removing script "type" attributes which are now invalid HTML. The patch also removes "CDATA" markers from script blocks. They have been unnecessary since we stopped using an XHTML doctype. To test, apply the patch and look at various pages in the staff client to confirm that no JavaScript-driven interactions are broken. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 88568 [details] [review] Bug 21784: Clean up js_includes.inc This patch cleans up js_includes.inc by removing script "type" attributes which are now invalid HTML. The patch also removes "CDATA" markers from script blocks. They have been unnecessary since we stopped using an XHTML doctype. To test, apply the patch and look at various pages in the staff client to confirm that no JavaScript-driven interactions are broken. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Enhancement will not be backported into 18.11.x series. |