Bug 21795

Summary: Switch two-column templates to Bootstrap grid: Notices and slips
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: enhancement    
Priority: P5 - low CC: cbrannon, josef.moravec, martin.renvoize, nick, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 20654, 21802    
Attachments: Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips
[SIGNED OFF] Attachment to Bug 21795 - Switch two-column templates to Bootstrap grid: Notices and slips
[SIGNED OFF] Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips
Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips

Description Owen Leonard 2018-11-08 17:52:08 UTC
letter.tt was partially updated during the conversion of single-column templates, but needs to be completed. The notice preview template needs to be completely revised.
Comment 1 Owen Leonard 2018-11-08 17:59:11 UTC
Created attachment 82108 [details] [review]
Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips

This patch updates notices and slips templates to use Bootstrap grids
instead of YUI.

This patch also removes obsolete "text/css" attributes from <style> tags
in the modified templates.

To test, apply the patch and go to Tools -> Notices and slips. Test that
these pages look correct and adujst well to various browser widths.

 - The main page listing notices and slips
 - The add/edit form
 - The notice preview modal available when editing CHECKIN, CHECKOUT and
   HOLD_SLIP.
Comment 2 Christopher Brannon 2018-11-08 19:48:22 UTC
Created attachment 82114 [details] [review]
[SIGNED OFF] Attachment to Bug 21795 - Switch two-column templates to Bootstrap grid: Notices and slips

Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips

This patch updates notices and slips templates to use Bootstrap grids
instead of YUI.

This patch also removes obsolete "text/css" attributes from <style> tags
in the modified templates.

To test, apply the patch and go to Tools -> Notices and slips. Test that
these pages look correct and adujst well to various browser widths.

 - The main page listing notices and slips
 - The add/edit form
 - The notice preview modal available when editing CHECKIN, CHECKOUT and
   HOLD_SLIP.
Comment 3 Christopher Brannon 2018-11-08 20:05:23 UTC
Created attachment 82115 [details] [review]
[SIGNED OFF] Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips

This patch updates notices and slips templates to use Bootstrap grids
instead of YUI.

This patch also removes obsolete "text/css" attributes from <style> tags
in the modified templates.

To test, apply the patch and go to Tools -> Notices and slips. Test that
these pages look correct and adujst well to various browser widths.

 - The main page listing notices and slips
 - The add/edit form
 - The notice preview modal available when editing CHECKIN, CHECKOUT and
   HOLD_SLIP.

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Comment 4 Josef Moravec 2018-11-09 15:05:29 UTC
Created attachment 82174 [details] [review]
Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips

This patch updates notices and slips templates to use Bootstrap grids
instead of YUI.

This patch also removes obsolete "text/css" attributes from <style> tags
in the modified templates.

To test, apply the patch and go to Tools -> Notices and slips. Test that
these pages look correct and adujst well to various browser widths.

 - The main page listing notices and slips
 - The add/edit form
 - The notice preview modal available when editing CHECKIN, CHECKOUT and
   HOLD_SLIP.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 5 Josef Moravec 2018-11-09 15:11:31 UTC
There is a glitch on edit form - it is not responsive inside the accordeon - the right border is not aligned with the accordeon headers - but this bug exists in master too, so passing qa and will open a new bug report for this.
Comment 6 Nick Clemens 2018-12-26 20:52:20 UTC
Awesome work all!

Pushed to master for 19.05
Comment 7 Martin Renvoize 2019-01-03 14:22:24 UTC
Enhancement, will not be backported to 18.11.x series