Summary: | Switch two-column templates to Bootstrap grid: Notices and slips | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | cbrannon, josef.moravec, martin.renvoize, nick, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 20654, 21802 | ||
Attachments: |
Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips
[SIGNED OFF] Attachment to Bug 21795 - Switch two-column templates to Bootstrap grid: Notices and slips [SIGNED OFF] Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips |
Description
Owen Leonard
2018-11-08 17:52:08 UTC
Created attachment 82108 [details] [review] Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips This patch updates notices and slips templates to use Bootstrap grids instead of YUI. This patch also removes obsolete "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and go to Tools -> Notices and slips. Test that these pages look correct and adujst well to various browser widths. - The main page listing notices and slips - The add/edit form - The notice preview modal available when editing CHECKIN, CHECKOUT and HOLD_SLIP. Created attachment 82114 [details] [review] [SIGNED OFF] Attachment to Bug 21795 - Switch two-column templates to Bootstrap grid: Notices and slips Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips This patch updates notices and slips templates to use Bootstrap grids instead of YUI. This patch also removes obsolete "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and go to Tools -> Notices and slips. Test that these pages look correct and adujst well to various browser widths. - The main page listing notices and slips - The add/edit form - The notice preview modal available when editing CHECKIN, CHECKOUT and HOLD_SLIP. Created attachment 82115 [details] [review] [SIGNED OFF] Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips This patch updates notices and slips templates to use Bootstrap grids instead of YUI. This patch also removes obsolete "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and go to Tools -> Notices and slips. Test that these pages look correct and adujst well to various browser widths. - The main page listing notices and slips - The add/edit form - The notice preview modal available when editing CHECKIN, CHECKOUT and HOLD_SLIP. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Created attachment 82174 [details] [review] Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips This patch updates notices and slips templates to use Bootstrap grids instead of YUI. This patch also removes obsolete "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and go to Tools -> Notices and slips. Test that these pages look correct and adujst well to various browser widths. - The main page listing notices and slips - The add/edit form - The notice preview modal available when editing CHECKIN, CHECKOUT and HOLD_SLIP. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> There is a glitch on edit form - it is not responsive inside the accordeon - the right border is not aligned with the accordeon headers - but this bug exists in master too, so passing qa and will open a new bug report for this. Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series |