Bug 21804

Summary: Bad rebase reintroduced C4::Accounts::getcharges
Product: Koha Reporter: Josef Moravec <josef.moravec>
Component: Architecture, internals, and plumbingAssignee: Josef Moravec <josef.moravec>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: martin.renvoize, tomascohen
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 20629    
Bug Blocks: 21683    
Attachments: Bug 21804: Remove C4::Accounts::getcharges again
Bug 21804: Remove C4::Accounts::getcharges again
Bug 21804: Remove C4::Accounts::getcharges again

Description Josef Moravec 2018-11-09 16:53:52 UTC

    
Comment 1 Josef Moravec 2018-11-09 16:56:25 UTC
Created attachment 82182 [details] [review]
Bug 21804: Remove C4::Accounts::getcharges again

Test plan:
1) git grep getcharges
  -> should return no occurences
2) prove t/db_dependent/Accounts.t
  -> should pass
Comment 2 Tomás Cohen Arazi 2018-11-09 17:43:32 UTC
Created attachment 82193 [details] [review]
Bug 21804: Remove C4::Accounts::getcharges again

Test plan:
1) git grep getcharges
  -> should return no occurences
2) prove t/db_dependent/Accounts.t
  -> should pass

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Martin Renvoize 2018-11-09 18:34:22 UTC
Created attachment 82194 [details] [review]
Bug 21804: Remove C4::Accounts::getcharges again

Test plan:
1) git grep getcharges
  -> should return no occurences
2) prove t/db_dependent/Accounts.t
  -> should pass

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2018-11-09 18:34:40 UTC
Passed
Comment 5 Josef Moravec 2018-11-10 06:33:43 UTC
Thanks guys for quick testing ;)
Comment 6 Tomás Cohen Arazi 2018-11-12 19:30:47 UTC
Pushed for 18.11. Thanks all!
Comment 7 Martin Renvoize 2018-11-16 14:18:39 UTC
Architectural enhancement, will not be backported to 18.05.x series.