| Summary: | Duplicate include file in search results template causes JS error | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> | 
| Component: | Templates | Assignee: | Owen Leonard <oleonard> | 
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> | 
| Severity: | major | ||
| Priority: | P5 - low | CC: | m.de.rooy, martin.renvoize, nick, pierre-marc.thibault | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | Bug 21805: Duplicate include file in search results template causes JS error Bug 21805: Duplicate include file in search results template causes JS error Bug 21805: Duplicate include file in search results template causes JS error | ||
| 
        
          Description
        
        
          Owen Leonard
        
        
        
        
          2018-11-09 18:56:31 UTC
        
       Created attachment 82197 [details] [review] Bug 21805: Duplicate include file in search results template causes JS error This patch removes a redundant include file, browser-strings.inc, from the top of the staff client search results template. The correctly-placed include is in the JavaScript block at the bottom of the template. The duplication causes a JavaScript error which can be seen in the browser console. To test, apply the patch and peform a catalog search in the staff client. Open the browser console and confirm that there are no errors. Created attachment 82202 [details] [review] Bug 21805: Duplicate include file in search results template causes JS error This patch removes a redundant include file, browser-strings.inc, from the top of the staff client search results template. The correctly-placed include is in the JavaScript block at the bottom of the template. The duplication causes a JavaScript error which can be seen in the browser console. To test, apply the patch and peform a catalog search in the staff client. Open the browser console and confirm that there are no errors. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Created attachment 82341 [details] [review] Bug 21805: Duplicate include file in search results template causes JS error This patch removes a redundant include file, browser-strings.inc, from the top of the staff client search results template. The correctly-placed include is in the JavaScript block at the bottom of the template. The duplication causes a JavaScript error which can be seen in the browser console. To test, apply the patch and peform a catalog search in the staff client. Open the browser console and confirm that there are no errors. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 18.11 Issue not in 18.05.x series. |