Bug 21808

Summary: Field 711 is not handled correctly in showAuthor XSLT for relator term or code
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: OPACAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, lucas, martin.renvoize, nick, pierre-marc.thibault
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code
Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code
Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code

Description Marcel de Rooy 2018-11-12 10:52:40 UTC
The following condition in xsl detail opac and staff looks at $j for field 111 but not for field 711 while it should too. The condition can be written a bit easier to read (without self, parent, etc.)

<xsl:if test="marc:subfield[@code='4' or @code='e'][not(parent::*[@tag=111])] or (self::*[@tag=111] and marc:subfield[@code='4' or @code='j'][. != ''])">
Comment 1 Marcel de Rooy 2018-11-12 11:03:45 UTC
Created attachment 82222 [details] [review]
Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code

The test should check $4 or $e for fields ne 111,711.
And should check $4 or $j for 111,711.

Test plan:
Edit a record, add a meeting in 711 without $4 but with $j.
Without this patch the term is not visible, with this patch it is.
Comment 2 Pierre-Marc Thibault 2018-11-16 20:55:47 UTC
Created attachment 82418 [details] [review]
Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code

The test should check $4 or $e for fields ne 111,711.
And should check $4 or $j for 111,711.

Test plan:
Edit a record, add a meeting in 711 without $4 but with $j.
Without this patch the term is not visible, with this patch it is.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Comment 3 Kyle M Hall 2019-02-04 12:44:38 UTC
Created attachment 84699 [details] [review]
Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code

The test should check $4 or $e for fields ne 111,711.
And should check $4 or $j for 111,711.

Test plan:
Edit a record, add a meeting in 711 without $4 but with $j.
Without this patch the term is not visible, with this patch it is.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Marcel de Rooy 2019-02-04 12:45:49 UTC
(In reply to Kyle M Hall from comment #3)
> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Thx
Comment 5 Nick Clemens (kidclamp) 2019-02-04 17:45:28 UTC
Awesome work all!

Pushed to master for 19.05
Comment 6 Martin Renvoize 2019-02-11 13:46:23 UTC
Pushed to 18.11.x for 18.11.03
Comment 7 Lucas Gass 2019-02-12 21:18:22 UTC
backported to 18.05.x for 18.05.09
Comment 8 Fridolin Somers 2019-02-15 07:05:26 UTC
Pushed to 17.11.x for 17.11.15