Summary: | Request ID is displayed as NaN | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Isherwood <bugzilla> |
Component: | ILL | Assignee: | Andrew Isherwood <bugzilla> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | m.de.rooy, magnus, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 20996 | ||
Bug Blocks: | 20640 | ||
Attachments: |
Bug 21835: Fix display of request ID
Bug 21835: Fix display of request ID Bug 21835: Fix display of request ID Bug 21835: (QA follow-up) Fix failing test |
Description
Andrew Isherwood
2018-11-14 15:48:28 UTC
Created attachment 82342 [details] [review] Bug 21835: Fix display of request ID We now populate the id_prefix property in the API response. It turns out that explicitly casting to a string wasn't necessary as JS does "the right thing" when concatenating a string and an integer Test plan: - Before applying the patch view the ILL requests table - TEST: Observe that the Request number column displays as NaN - Apply the patch - Refresh the page - TEST: Observe that the request number now displays correctly - Add the following block to your koha-conf.xml: <branch> <code>**The code of a branch that has an ILL request attached to it**</code> <prefix>YAY</prefix> </branch> - Refresh the page - TEST: Observe the request made on the branch that you specified in the config are now prefixed with "YAY-" Created attachment 82343 [details] [review] Bug 21835: Fix display of request ID We now populate the id_prefix property in the API response. It turns out that explicitly casting to a string wasn't necessary as JS does "the right thing" when concatenating a string and an integer Test plan: - Before applying the patch view the ILL requests table - TEST: Observe that the Request number column displays as NaN - Apply the patch - Refresh the page - TEST: Observe that the request number now displays correctly - Add the following block to your koha-conf.xml: <branch> <code>**The code of a branch that has an ILL request attached to it**</code> <prefix>YAY</prefix> </branch> - Refresh the page - TEST: Observe the request made on the branch that you specified in the config are now prefixed with "YAY-" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 82381 [details] [review] Bug 21835: Fix display of request ID We now populate the id_prefix property in the API response. It turns out that explicitly casting to a string wasn't necessary as JS does "the right thing" when concatenating a string and an integer Test plan: - Before applying the patch view the ILL requests table - TEST: Observe that the Request number column displays as NaN - Apply the patch - Refresh the page - TEST: Observe that the request number now displays correctly - Add the following block to your koha-conf.xml: <branch> <code>**The code of a branch that has an ILL request attached to it**</code> <prefix>YAY</prefix> </branch> - Refresh the page - TEST: Observe the request made on the branch that you specified in the config are now prefixed with "YAY-" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 18.11 Created attachment 82405 [details] [review] Bug 21835: (QA follow-up) Fix failing test The illrequest api response should always be augmented with an id_prefix field which is not part of the core illrequest object Not required for 18.05.x series. |