Bug 21838

Summary: Wrong alignment of instructors in course reserves
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: lucas, m.de.rooy, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Screenshot (Error)
Bug 21838: Wrong alignment of instructors in course reserves
Bug 21838: Wrong alignment of instructors in course reserves
Bug 21838: Wrong alignment of instructors in course reserves
Bug 21838: Wrong alignment of instructors in course reserves

Description Tomás Cohen Arazi 2018-11-14 21:07:54 UTC
If you add more than one instructor, they are not aligned correctly.
Comment 1 Tomás Cohen Arazi 2018-11-14 21:08:47 UTC
Created attachment 82348 [details]
Screenshot (Error)
Comment 2 Owen Leonard 2018-11-15 13:44:34 UTC
Created attachment 82360 [details] [review]
Bug 21838: Wrong alignment of instructors in course reserves

This patch adds CSS to course reserve pages so that multiple instructors
on a course are displayed well.

To test, apply the patch and:

 - Add or edit a course.
   - Test adding and removing instructors, saving, and adding and removing
     again.
 - View a course with multiple instructors and confirm that they are
   displayed well.
Comment 3 Tomás Cohen Arazi 2018-11-16 01:31:47 UTC
Created attachment 82376 [details] [review]
Bug 21838: Wrong alignment of instructors in course reserves

This patch adds CSS to course reserve pages so that multiple instructors
on a course are displayed well.

To test, apply the patch and:

 - Add or edit a course.
   - Test adding and removing instructors, saving, and adding and removing
     again.
 - View a course with multiple instructors and confirm that they are
   displayed well.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Awesome, Owen :-D
Comment 4 Marcel de Rooy 2018-11-16 06:58:28 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2018-11-16 07:01:20 UTC
Created attachment 82380 [details] [review]
Bug 21838: Wrong alignment of instructors in course reserves

This patch adds CSS to course reserve pages so that multiple instructors
on a course are displayed well.

To test, apply the patch and:

 - Add or edit a course.
   - Test adding and removing instructors, saving, and adding and removing
     again.
 - View a course with multiple instructors and confirm that they are
   displayed well.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Awesome, Owen :-D

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Nick Clemens (kidclamp) 2018-11-16 13:11:01 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Lucas Gass 2018-12-04 19:53:37 UTC
unable to backport cleanly to 18.05. failed qa test:

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  spelling
   OK	  tt_valid
   FAIL	  valid_template
		Attempt to reload Koha/Template/Plugin/Koha.pm aborted.
Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Plugins.pm line 206.