Summary: | Sort of issues in OPAC subscription table | ||
---|---|---|---|
Product: | Koha | Reporter: | Marjorie Barry-Vila <marjorie.barry-vila> |
Component: | Serials | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, imelda.bennis, jonathan.druart, lucas, martin.renvoize, mikael.olangcay-brisebois, nick, patrick.robitaille |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 11976 | ||
Bug Blocks: | |||
Attachments: |
subscription table
Bug 21845: Sort of issues in OPAC subscription table Bug 21845: Sort of issues in OPAC subscription table Bug 21845: Sort of issues in OPAC subscription table |
It looks to me like the sorting of the table changed arbitrarily--DataTables sorts by the first column by default if no sorting option is set. This overrode the sorting of the data passed by the script (publisheddate). So, a regression of sorts. heh. Created attachment 84360 [details] [review] Bug 21845: Sort of issues in OPAC subscription table This patch adds a default sort option to the table of subscriptions on the OPAC detail page. This sorting option matches the sort of data passed from GetLatestSerials. To test, apply the patch and locate a subscription in the OPAC which has multiple issues. They should be sorted by default on publication date. Created attachment 84429 [details] [review] Bug 21845: Sort of issues in OPAC subscription table This patch adds a default sort option to the table of subscriptions on the OPAC detail page. This sorting option matches the sort of data passed from GetLatestSerials. To test, apply the patch and locate a subscription in the OPAC which has multiple issues. They should be sorted by default on publication date. Signed-off-by: mikael <mikael.Olangcay-Brisebois@inlibro.com> Mikaël, it seems that you forgot to change the status to "Signed Off". Created attachment 85206 [details] [review] Bug 21845: Sort of issues in OPAC subscription table This patch adds a default sort option to the table of subscriptions on the OPAC detail page. This sorting option matches the sort of data passed from GetLatestSerials. To test, apply the patch and locate a subscription in the OPAC which has multiple issues. They should be sorted by default on publication date. Signed-off-by: mikael <mikael.Olangcay-Brisebois@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This restores the former behavior with the newest issue on top of the list. It could be a little irritating if the column for date published is hidden with the column settings, as it appears it will still sort on the hidden column. Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 backported to 18.05.x for 18.05.11 |
Created attachment 82374 [details] subscription table Hi, With patch 11976, subscription table display is in column settings in the administration. Default sort of issues is now ascending while in previous versions default sorting was descending on the last received issues. Can a system preference be added to configure sorting on subscription table? It makes more sense to see the last issue at the top of the table. Regards, Marjorie