Bug 21867

Summary: Replace remaining document.element.onchange calls in marc_modification_templates.js
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, jesse, josef.moravec, nick
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 21819    
Bug Blocks: 21861    
Attachments: Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js
Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js
Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js
Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js

Description Marcel de Rooy 2018-11-20 15:39:49 UTC
See also bug 21819.
Comment 1 Marcel de Rooy 2018-11-20 15:49:38 UTC
Created attachment 82553 [details] [review]
Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js

Replace onchange() by jQuery change().

Test plan:
Go to marc mod templates. Add, edit and delete. Check if works and no js
errors.
git grep -l -E "onchange\(" should not have occurrences outside lib.
Comment 2 Owen Leonard 2018-11-20 16:08:36 UTC
Created attachment 82554 [details] [review]
Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js

Replace onchange() by jQuery change().

Test plan:
Go to marc mod templates. Add, edit and delete. Check if works and no js
errors.
git grep -l -E "onchange\(" should not have occurrences outside lib.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Andreas Roussos 2018-11-20 16:37:39 UTC
Created attachment 82556 [details] [review]
Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js

Replace onchange() by jQuery change().

Test plan:
Go to marc mod templates. Add, edit and delete. Check if works and no js
errors.
git grep -l -E "onchange\(" should not have occurrences outside lib.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Andreas Roussos <arouss1980@gmail.com>
Comment 4 Marcel de Rooy 2018-11-21 12:05:31 UTC
> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
> Signed-off-by: Andreas Roussos <arouss1980@gmail.com>

Thanks
Comment 5 Josef Moravec 2018-11-26 19:50:31 UTC
Created attachment 82655 [details] [review]
Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js

Replace onchange() by jQuery change().

Test plan:
Go to marc mod templates. Add, edit and delete. Check if works and no js
errors.
git grep -l -E "onchange\(" should not have occurrences outside lib.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Andreas Roussos <arouss1980@gmail.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 6 Nick Clemens 2018-11-27 01:20:46 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Jesse Maseto 2018-12-07 22:06:29 UTC
Backported to 18.05 for 18.05.07
Comment 8 Fridolin Somers 2018-12-19 09:51:37 UTC
Pushed to 17.11.x for 17.11.13