Description
Marcel de Rooy
2018-11-20 15:39:49 UTC
Created attachment 82553 [details] [review] Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js Replace onchange() by jQuery change(). Test plan: Go to marc mod templates. Add, edit and delete. Check if works and no js errors. git grep -l -E "onchange\(" should not have occurrences outside lib. Created attachment 82554 [details] [review] Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js Replace onchange() by jQuery change(). Test plan: Go to marc mod templates. Add, edit and delete. Check if works and no js errors. git grep -l -E "onchange\(" should not have occurrences outside lib. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 82556 [details] [review] Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js Replace onchange() by jQuery change(). Test plan: Go to marc mod templates. Add, edit and delete. Check if works and no js errors. git grep -l -E "onchange\(" should not have occurrences outside lib. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andreas Roussos <arouss1980@gmail.com> > Signed-off-by: Owen Leonard <oleonard@myacpl.org>
> Signed-off-by: Andreas Roussos <arouss1980@gmail.com>
Thanks
Created attachment 82655 [details] [review] Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js Replace onchange() by jQuery change(). Test plan: Go to marc mod templates. Add, edit and delete. Check if works and no js errors. git grep -l -E "onchange\(" should not have occurrences outside lib. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andreas Roussos <arouss1980@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 18.11 Backported to 18.05 for 18.05.07 Pushed to 17.11.x for 17.11.13 |