Description
Owen Leonard
2018-11-21 13:48:52 UTC
Created attachment 82568 [details] [review] Bug 21871: Show authority 856 links in the OPAC This patch modifies the authority detail view in the OPAC so that any links found in 856 tags are displayed and active. To test, apply the patch and locate or create an authority record which contains one or more URLs in 856 tags. - View this record in the OPAC and confirm that the links appear. - Test records with and without link text. - Test records with and without public notes. Created attachment 82596 [details] [review] Bug 21871: Show authority 856 links in the OPAC This patch modifies the authority detail view in the OPAC so that any links found in 856 tags are displayed and active. To test, apply the patch and locate or create an authority record which contains one or more URLs in 856 tags. - View this record in the OPAC and confirm that the links appear. - Test records with and without link text. - Test records with and without public notes. All tested and it worked, nice job Owen. What do you think about to add similar links in Intranet authorities detail page so librarians can directly reach the resource when they click them? Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Created attachment 83834 [details] [review] Bug 21871: Show authority 856 links in the OPAC This patch modifies the authority detail view in the OPAC so that any links found in 856 tags are displayed and active. To test, apply the patch and locate or create an authority record which contains one or more URLs in 856 tags. - View this record in the OPAC and confirm that the links appear. - Test records with and without link text. - Test records with and without public notes. Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> The display works, but I think the code for the TrackClicks should not be there. The linktracker table only has a bilbionumber column, nothing is tracked there if you click on the authority links now. I suggest removing it and adding a separate bug to make it possible to track links for authorities. Created attachment 84005 [details] [review] Bug 21871: (follow-up) Remove link tracking Links to tracklinks.pl were erroneously copied from detail.tt. This patch removes them. Created attachment 84223 [details] [review] Bug 21871: (follow-up) Remove link tracking Links to tracklinks.pl were erroneously copied from detail.tt. This patch removes them. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Created attachment 84466 [details] [review] Bug 21871: Show authority 856 links in the OPAC This patch modifies the authority detail view in the OPAC so that any links found in 856 tags are displayed and active. To test, apply the patch and locate or create an authority record which contains one or more URLs in 856 tags. - View this record in the OPAC and confirm that the links appear. - Test records with and without link text. - Test records with and without public notes. Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 84467 [details] [review] Bug 21871: (follow-up) Remove link tracking Links to tracklinks.pl were erroneously copied from detail.tt. This patch removes them. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 84468 [details] [review] Bug 21871: Show authority 856 links in the OPAC This patch modifies the authority detail view in the OPAC so that any links found in 856 tags are displayed and active. To test, apply the patch and locate or create an authority record which contains one or more URLs in 856 tags. - View this record in the OPAC and confirm that the links appear. - Test records with and without link text. - Test records with and without public notes. Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=21817 Created attachment 84469 [details] [review] Bug 21871: (follow-up) Remove link tracking Links to tracklinks.pl were erroneously copied from detail.tt. This patch removes them. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=21817 Created attachment 84470 [details] [review] Bug 21871: (QA follow-up) Use Koha.Preference in template Use TT plugin to get value for OPACURLOpenInNewWindow. Works without, but might be a little nicer. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=21817 Created attachment 84471 [details] [review] Bug 21871: (QA follow-up) C4::Biblio qw(GetMarcUrls) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=21817 Suggesting 2 follow-ups: I think it's a tiny bit irritating to use something from Biblio in authorities... but I know we will get to make this all shiny at some point with the new API. Added a qw() to help remember what we exactly need this for here. Suggest use of TT plugin in the template. Kept them separate, so you can pick and choose :) Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series. |