Summary: | Fix few links for opac pagination and facets (no uri filter) | ||
---|---|---|---|
Product: | Koha | Reporter: | Devinim <kohadevinim> |
Component: | OPAC | Assignee: | Devinim <kohadevinim> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | lucas, m.de.rooy, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 21526 | ||
Bug Blocks: | 21950 | ||
Attachments: |
Bug 21878: To fix pagination problem in OPAC
Bug 21878: To fix pagination problem in OPAC Bug 21878: (follow-up) Fix a few query_cgi filters in opac-search-history Bug 21878: (follow-up) Fix a few uri filter in facets Bug 21878: To fix pagination problem in OPAC Bug 21878: To fix pagination problem in OPAC Bug 21878: (follow-up) Fix a few query_cgi filters in opac-search-history Bug 21878: (follow-up) Fix a few uri filter in facets |
Description
Devinim
2018-11-23 14:19:27 UTC
Created attachment 82617 [details] [review] Bug 21878: To fix pagination problem in OPAC Due to conversions from html to uri in various places pagination in OPAC doesnot work properly. This change will resolve pagination problem. QA: Looking here Created attachment 82630 [details] [review] Bug 21878: To fix pagination problem in OPAC Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 82631 [details] [review] Bug 21878: (follow-up) Fix a few query_cgi filters in opac-search-history We need to replace the uri filter on query_cgi to make some URLs work. Test plan: Check if the links on user page, search history work for biblio and auth in current and previous release. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 82632 [details] [review] Bug 21878: (follow-up) Fix a few uri filter in facets We need to adjust a few query_cgi | uri filters here too. Note that sort_by should be filtered by uri, not url. Similar change on staff side. Test plan: Toggle Show all items/Limit available items. Check: git grep -l "query_cgi | uri" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 82643 [details] [review] Bug 21878: To fix pagination problem in OPAC Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 82644 [details] [review] Bug 21878: To fix pagination problem in OPAC Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 82645 [details] [review] Bug 21878: (follow-up) Fix a few query_cgi filters in opac-search-history We need to replace the uri filter on query_cgi to make some URLs work. Test plan: Check if the links on user page, search history work for biblio and auth in current and previous release. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 82646 [details] [review] Bug 21878: (follow-up) Fix a few uri filter in facets We need to adjust a few query_cgi | uri filters here too. Note that sort_by should be filtered by uri, not url. Similar change on staff side. Test plan: Toggle Show all items/Limit available items. Check: git grep -l "query_cgi | uri" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Awesome work all! Pushed to master for 18.11 depends on 13618, not backporting to 18.05 |