Summary: | Code cleaning in printinvoice.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Devinim <kohadevinim> |
Component: | Fines and fees | Assignee: | Devinim <kohadevinim> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, black23, gmcharlt, hayleypelham, jonathan.druart, kyle.m.hall, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.00, 19.11.05, 19.05.10
|
Circulation function: | |
Bug Depends on: | 19489 | ||
Bug Blocks: | |||
Attachments: |
Bug 21879: Code cleaning in printinvoice.pl
Bug 21879: Code cleaning in printinvoice.pl Bug 21879: Code cleaning in printinvoice.pl Bug 21879: Code cleaning in printinvoice.pl |
Description
Devinim
2018-11-23 14:55:43 UTC
Created attachment 82618 [details] [review] Bug 21879: Code cleaning in printinvoice.pl Hi, any test plan? Hi Michal, This patch depends on the patch of Bug 19489. After applying patch 19489 and test all steps you should apply this and then check whether it is working as expected. Thanks. Devinim Koha Team Hi, I get: Applying: Bug 21879: Code cleaning in printinvoice.pl error: sha1 information is lacking or useless (members/printinvoice.pl). error: could not build fake ancestor Patch failed at 0001 Bug 21879: Code cleaning in printinvoice.pl The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21879-Code-cleaning-in-printinvoicepl-SF3uPq.patch Please rebase patch. Created attachment 99385 [details] [review] Bug 21879: Code cleaning in printinvoice.pl The problem is solved. Please apply again. Created attachment 99651 [details] [review] Bug 21879: Code cleaning in printinvoice.pl Coming from commit 51aa6db46c604aa202a3d8f8e5028557480efbd5 Bug 12001: Move GetMemberAccountRecords to the Koha namespace Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial, dead code. Skipping QA. Created attachment 99653 [details] [review] Bug 21879: Code cleaning in printinvoice.pl Coming from commit 51aa6db46c604aa202a3d8f8e5028557480efbd5 Bug 12001: Move GetMemberAccountRecords to the Koha namespace Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Haha, you beat me to it. Nice work everyone! Pushed to master for 20.05 backported to 19.11.x for 19.11.05 backported to 19.05.x for 19.05.10 Minor/enhancement will not be backported to 18.11.x series |