| Summary: | Clean up payment details page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, josef.moravec, kohadevinim, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/members/accountline-details.pl?accountlines_id=XXX | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 20654 | ||
| Attachments: |
Bug 21913: Clean up payment details page
Bug 21913: Clean up payment details page Bug 21913: Clean up payment details page Bug 21913: Clean up payment details page |
||
|
Description
Owen Leonard
2018-11-29 15:52:59 UTC
Created attachment 82757 [details] [review] Bug 21913: Clean up payment details page This patch makes various corrections and improvements to the payment details page: - Grid converted to Bootstrap - Correct title tag - Add patron toolbar - Adding missing patron-related JavaScript - Improve some language To test, apply the patch and locate a patron who has one or more payments on their account. - Open Fines -> Account -> Details of a transaction - Confirm that the page looks correct and adjusts well at various browser widths. - Confirm that patron toolbar items work correctly - Confirm that the payments table only appears when there are payments to list. İf there isn't any payment, payment section appears. Other functionalities are working as described. (In reply to Devinim from comment #2) > İf there isn't any payment, payment section appears. Other functionalities > are working as described. Failing QA for that as it is advertised in the commit message. (In reply to Jonathan Druart from comment #3) > (In reply to Devinim from comment #2) > > İf there isn't any payment, payment section appears. Other functionalities > > are working as described. > > Failing QA for that as it is advertised in the commit message. Hi Jonathan, We didn't understand this :( Can you explain a bit more? Thanks. Created attachment 83793 [details] [review] Bug 21913: Clean up payment details page This patch makes various corrections and improvements to the payment details page: - Grid converted to Bootstrap - Correct title tag - Add patron toolbar - Adding missing patron-related JavaScript - Improve some language To test, apply the patch and locate a patron who has one or more payments on their account. - Open Fines -> Account -> Details of a transaction - Confirm that the page looks correct and adjusts well at various browser widths. - Confirm that patron toolbar items work correctly (In reply to Jonathan Druart from comment #3) > (In reply to Devinim from comment #2) > > İf there isn't any payment, payment section appears. Other functionalities > > are working as described. > > Failing QA for that as it is advertised in the commit message. I removed those changes. There wasn't a straightforward way to accomplish it with template changes. Created attachment 83828 [details] [review] Bug 21913: Clean up payment details page This patch makes various corrections and improvements to the payment details page: - Grid converted to Bootstrap - Correct title tag - Add patron toolbar - Adding missing patron-related JavaScript - Improve some language To test, apply the patch and locate a patron who has one or more payments on their account. - Open Fines -> Account -> Details of a transaction - Confirm that the page looks correct and adjusts well at various browser widths. - Confirm that patron toolbar items work correctly Signed-off-by: Jose-Mario <jose-mario.monteiro-santos@inLibro.com> Created attachment 83848 [details] [review] Bug 21913: Clean up payment details page This patch makes various corrections and improvements to the payment details page: - Grid converted to Bootstrap - Correct title tag - Add patron toolbar - Adding missing patron-related JavaScript - Improve some language To test, apply the patch and locate a patron who has one or more payments on their account. - Open Fines -> Account -> Details of a transaction - Confirm that the page looks correct and adjusts well at various browser widths. - Confirm that patron toolbar items work correctly Signed-off-by: Jose-Mario <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series. |