Summary: | Typo in the manage_circ_rules_from_any_libraries description | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Patrons | Assignee: | Jack <jke0429> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, david, fridolin.somers, gmcharlt, jesse, jke0429, katrin.fischer, kyle.m.hall, martin.renvoize, nick |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 22149 | ||
Attachments: |
BUG 21930: Reworded message on permissions.inc
BUG 21930: Reworded message on permissions.inc Bug 21930: Reworded message on permissions.inc |
Description
Caroline Cyr La Rose
2018-11-30 22:51:02 UTC
I'd also rephrase it a bit, suggestion: any libraries = any library from its own library = their own library Manage circulation rules form any library. If not set the logged in user can only edit circulation rules from their own library (please note that manage_circ_rules is still required). Created attachment 83930 [details] [review] BUG 21930: Reworded message on permissions.inc 1. Go to patrons account, more, Set Permissions. 2. Dropdown the Parameters section. 3. Text should display "If not set the logged in user could only edit circulation rules for its the own library (please note that manage_circ_rules is still required)" 4. Apply patch and reload page 5. Text should now display "Edit circulation rules from any library. If not set the logged in user could only edit circulation rules for their own library (please note that manage_circ_rules is still required)" To check the current and updated wording: 1. Go to the Patrons screen 2. Search or browse for a patron 3. Click on the link for the patron's name in the Name column (result: should end on the details screen for the patron) 4. From the buttons above the patron name select More > Set permissions 5. Expand the list of options under (parameters) Manage Koha system settings (Administration panel) (Note: I've only added this as I'm not familiar with the patrons area and it took me ages to find where this was ...) Note: I prefer Katrin's wording, but I don't know whether I understand what exactly is required for the wording, except to remove 'the': "Manage circulation rules from any library. If not set the logged in user can only edit circulation rules from their own library (please note that manage_circ_rules is still required)." Should 'from' in both occurences be 'for'? Created attachment 83942 [details] [review] BUG 21930: Reworded message on permissions.inc 1. Go to patrons account, more, Set Permissions. 2. Dropdown the Parameters section. 3. Text should display "If not set the logged in user could only edit circulation rules for its the own library (please note that manage_circ_rules is still required)" 4. Apply patch and reload page 5. Text should now display "Edit circulation rules from any library. If not set the logged in user could only edit circulation rules for their own library (please note that manage_circ_rules is still required)" Signed-off-by: David Nind <david@davidnind.com> Created attachment 84084 [details] [review] Bug 21930: Reworded message on permissions.inc 1. Go to patrons account, more, Set Permissions. 2. Dropdown the Parameters section. 3. Text should display "If not set the logged in user could only edit circulation rules for its the own library (please note that manage_circ_rules is still required)" 4. Apply patch and reload page 5. Text should now display "Edit circulation rules from any library. If not set the logged in user could only edit circulation rules for their own library (please note that manage_circ_rules is still required)" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to David Nind from comment #4) > Note: I prefer Katrin's wording, but I don't know whether I understand what > exactly is required for the wording, except to remove 'the': > > "Manage circulation rules from any library. If not set the logged in user can > only edit circulation rules from their own library (please note that > manage_circ_rules is still required)." > > Should 'from' in both occurences be 'for'? I have made Bug 22149 for this to be fixed. Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.03 Pushed to 18.05.x for 18.05.09 I prefer not push to 17.11.x to avoid translation work |