| Summary: | Upgrade from 3.22 fails when running updatedatabase.pl script | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Alex Bernier <alex.bernier> |
| Component: | Database | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | alex.bernier, fridolin.somers, jonathan.druart, lucas, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 19789 | ||
| Attachments: |
Fix updatedatabase.pl
Bug 21931: Do not reset the ES mapping on 3.23.00.050 Bug 21931: Do not reset the ES mapping on 3.23.00.050 Bug 21931: Do not reset the ES mapping on 3.23.00.050 |
||
|
Description
Alex Bernier
2018-12-01 17:20:41 UTC
Created attachment 82822 [details]
Fix updatedatabase.pl
Created attachment 83001 [details] [review] Bug 21931: Do not reset the ES mapping on 3.23.00.050 This update DB entry uses DBIx schema which does not make it crashes if the table structure is changed. Which happens on 18.06.00.054, that added search_field.weight The entry 3.23.00.050 fails with Unknown column 'me.weight' in 'field list' This patch removes the reset of the mapping and display a warning to tell the administrator the mapping must be reset/inserted Test plan: Use a 3.22 dump and upgrade it Hi Alex, Thanks for reporting it. I have proposed another approach: remove the reset of the ES mappings. It will make it more robust as it will not explode in the future if the table structure changed again. Do not forget to change the status when you submit a patch that is ready to be tested. Created attachment 83166 [details] [review] Bug 21931: Do not reset the ES mapping on 3.23.00.050 This update DB entry uses DBIx schema which does not make it crashes if the table structure is changed. Which happens on 18.06.00.054, that added search_field.weight The entry 3.23.00.050 fails with Unknown column 'me.weight' in 'field list' This patch removes the reset of the mapping and display a warning to tell the administrator the mapping must be reset/inserted Test plan: Use a 3.22 dump and upgrade it Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83171 [details] [review] Bug 21931: Do not reset the ES mapping on 3.23.00.050 This update DB entry uses DBIx schema which does not make it crashes if the table structure is changed. Which happens on 18.06.00.054, that added search_field.weight The entry 3.23.00.050 fails with Unknown column 'me.weight' in 'field list' This patch removes the reset of the mapping and display a warning to tell the administrator the mapping must be reset/inserted Test plan: Use a 3.22 dump and upgrade it Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Passing QA here.. a sound fix. Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.01 backported to 18.05 for 18.05.08 Pushed to 17.11.x for 17.11.14 |