Bug 21943

Summary: Clean up holds template
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: martin.renvoize, nick, testopia, wizzyrea
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
19.05.00
Bug Depends on:    
Bug Blocks: 14546    
Attachments: Bug 21943: Clean up holds template
Screenshot of responsive view
Bug 21943: (follow-up) Fix float error with sidebar menu
Bug 21943: Clean up holds template
Bug 21943: (follow-up) Fix float error with sidebar menu
Bug 21943: Clean up holds template
Bug 21943: (follow-up) Fix float error with sidebar menu

Description Owen Leonard 2018-12-04 16:26:20 UTC
There are some minor markup issues with the holds template in the staff client, including needing a Bootstrap grid upgrade.
Comment 1 Owen Leonard 2018-12-04 16:32:14 UTC
Created attachment 82847 [details] [review]
Bug 21943: Clean up holds template

This patch makes a few markup corrections to the holds template in the
staff client: Replace some YUI markup with Bootstrap; Replace invalid
"alt" attributes with "title."

To test, apply the patch and test the process of placing a hold, both
single and multiple holds. At each step of the process the page should
look correct and adjust well at various browser widths.
Comment 2 Liz Rea 2019-03-07 17:17:00 UTC
Created attachment 86305 [details]
Screenshot of responsive view

Hi,

Sorry the responsive view doesn't look quite right. Have a look?

Cheers,
Liz
Comment 3 Owen Leonard 2019-03-11 13:50:29 UTC
Created attachment 86454 [details] [review]
Bug 21943: (follow-up) Fix float error with sidebar menu

This patch makes a minor change to the staff client CSS to fix a float
clearing problem when the <main> element contains only a floated element
like <fieldset>. It is a global change, but shouldn't cause unwanted
effects because a non-clearing <main> isn't used in any
float-dependent layouts.

To test, apply the patch and regenerate the staff client CSS. View the
place hold screen and confirm that the sidebar menu looks correct at
narrower browser widths.
Comment 4 Liz Rea 2019-04-08 16:01:28 UTC
Created attachment 87533 [details] [review]
Bug 21943: Clean up holds template

This patch makes a few markup corrections to the holds template in the
staff client: Replace some YUI markup with Bootstrap; Replace invalid
"alt" attributes with "title."

To test, apply the patch and test the process of placing a hold, both
single and multiple holds. At each step of the process the page should
look correct and adjust well at various browser widths.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment 5 Liz Rea 2019-04-08 16:01:31 UTC
Created attachment 87534 [details] [review]
Bug 21943: (follow-up) Fix float error with sidebar menu

This patch makes a minor change to the staff client CSS to fix a float
clearing problem when the <main> element contains only a floated element
like <fieldset>. It is a global change, but shouldn't cause unwanted
effects because a non-clearing <main> isn't used in any
float-dependent layouts.

To test, apply the patch and regenerate the staff client CSS. View the
place hold screen and confirm that the sidebar menu looks correct at
narrower browser widths.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment 6 Katrin Fischer 2019-04-08 21:21:08 UTC
Created attachment 87554 [details] [review]
Bug 21943: Clean up holds template

This patch makes a few markup corrections to the holds template in the
staff client: Replace some YUI markup with Bootstrap; Replace invalid
"alt" attributes with "title."

To test, apply the patch and test the process of placing a hold, both
single and multiple holds. At each step of the process the page should
look correct and adjust well at various browser widths.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2019-04-08 21:21:12 UTC
Created attachment 87555 [details] [review]
Bug 21943: (follow-up) Fix float error with sidebar menu

This patch makes a minor change to the staff client CSS to fix a float
clearing problem when the <main> element contains only a floated element
like <fieldset>. It is a global change, but shouldn't cause unwanted
effects because a non-clearing <main> isn't used in any
float-dependent layouts.

To test, apply the patch and regenerate the staff client CSS. View the
place hold screen and confirm that the sidebar menu looks correct at
narrower browser widths.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Nick Clemens 2019-04-17 12:27:41 UTC
Awesome work all!

Pushed to master for 19.05
Comment 9 Martin Renvoize 2019-04-26 13:18:17 UTC
Enhancement will not be backported to 18.11.x series.