|
Description
Nick Clemens (kidclamp)
2018-12-05 21:05:14 UTC
Created attachment 82893 [details] [review] Bug 21957: Add a flag to ModBiblio to avoid linking auths if called from linker To test: 1 - prove -v t/db_dependent/Biblio.t 2 - Set BiblioAddsAuthoorities and AutoCreateAuthorities 3 - Modify a biblio to add a heading with no existing auth record 4 - Ensure the record was created on saving 5 - Ensure that editing works as normal otherwise 6 - Run link_bibs_to_authorities 7 - Ensure results are as expected You add this parameter. I would expect it to be used somewhere in the misc script for instance? What am I missing? (In reply to Marcel de Rooy from comment #2) > You add this parameter. I would expect it to be used somewhere in the misc > script for instance? What am I missing? Looks like I missed a 'git add' Created attachment 84313 [details] [review] Bug 21957: Add a flag to ModBiblio to avoid linking auths if called from linker To test: 1 - prove -v t/db_dependent/Biblio.t 2 - Set BiblioAddsAuthoorities and AutoCreateAuthorities 3 - Modify a biblio to add a heading with no existing auth record 4 - Ensure the record was created on saving 5 - Ensure that editing works as normal otherwise 6 - Run link_bibs_to_authorities 7 - Ensure results are as expected I'd call the parameter something like $disable_autolink to convey its meaning, and check it first to avoid a call to C4::Context->preference() if $disable_autolink is true. Hi Nick, it`s ready for testing or some follow-up based on Ere's comment are coming? Thank you. Created attachment 88001 [details] [review] Bug 21957: Add a flag to ModBiblio to avoid linking auths if called from linker To test: 1 - prove -v t/db_dependent/Biblio.t 2 - Set BiblioAddsAuthoorities and AutoCreateAuthorities 3 - Modify a biblio to add a heading with no existing auth record 4 - Ensure the record was created on saving 5 - Ensure that editing works as normal otherwise 6 - Run link_bibs_to_authorities 7 - Ensure results are as expected (In reply to Michal Denar from comment #6) > Hi Nick, > it`s ready for testing or some follow-up based on Ere's comment are coming? > > Thank you. Ready now Great! Let's test it. Thank you. Created attachment 88033 [details] [review] Bug 21957: Add a flag to ModBiblio to avoid linking auths if called from linker To test: 1 - prove -v t/db_dependent/Biblio.t 2 - Set BiblioAddsAuthoorities and AutoCreateAuthorities 3 - Modify a biblio to add a heading with no existing auth record 4 - Ensure the record was created on saving 5 - Ensure that editing works as normal otherwise 6 - Run link_bibs_to_authorities 7 - Ensure results are as expected Signed-off-by: Michal Denar <black23@gmail.com> Created attachment 88161 [details] [review] Bug 21957: Add a flag to ModBiblio to avoid linking auths if called from linker To test: 1 - prove -v t/db_dependent/Biblio.t 2 - Set BiblioAddsAuthoorities and AutoCreateAuthorities 3 - Modify a biblio to add a heading with no existing auth record 4 - Ensure the record was created on saving 5 - Ensure that editing works as normal otherwise 6 - Run link_bibs_to_authorities 7 - Ensure results are as expected Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 i cannot rebase this and successfully prove -v t/db_dependent/Biblio.t in 18.05.x, if needed please rebase. Thanks |