| Summary: | TestBuilder::build_sample_item | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | lucas, m.de.rooy, martin.renvoize, nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 21798 | ||
| Bug Blocks: | 21816, 21985, 22140, 22392 | ||
| Attachments: |
Bug 21971: gimme_an_item
Bug 21971: TestBuilder::build_sample_item Bug 21971: TestBuilder::build_sample_item |
||
|
Description
Jonathan Druart
2018-12-06 22:51:30 UTC
Created attachment 82944 [details] [review] Bug 21971: gimme_an_item (In reply to Marcel de Rooy from comment #2) > gimme ? > See comment3 and 4 on bug 21798 I do not want to get stuck because of wording, substitution can be done easily if something else is suggested (which has not been done so far). (In reply to Jonathan Druart from comment #3) > (In reply to Marcel de Rooy from comment #2) > > gimme ? > > See comment3 and 4 on bug 21798 > > I do not want to get stuck because of wording, substitution can be done > easily if something else is suggested (which has not been done so far). Hmm. But if you are not the writer, different rules apply, heh ? Should not be very hard to suggest something else ;) What about create_item, create_test_item; build_item ? Created attachment 83139 [details] [review] Bug 21971: TestBuilder::build_sample_item fatal: sha1 information is lacking or useless (t/db_dependent/Circulation.t). I would expect to use builder inside build_sample_item and no longer see C4::Items::AddItem. No +1 from me ;) (In reply to Marcel de Rooy from comment #8) > I would expect to use builder inside build_sample_item and no longer see > C4::Items::AddItem. > No +1 from me ;) It does not work :) AddItem does much more than just creating a new row in the items table. Created attachment 83165 [details] [review] Bug 21971: TestBuilder::build_sample_item Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Same here, Nick, as on 21798. Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported at this time to 18.11.x series. Pushed to 18.11.x for 18.11.04 - This was required for bug 22140 enhancement not backporting to 18.05.x |