Summary: | Add some new Exceptions for Koha::Account methods | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 21002, 21727 | ||
Attachments: |
Bug 21980: Add new excpetions for Koha::Account
Bug 21980: Add new excpetions for Koha::Account Bug 21980: Add new excpetions for Koha::Account |
Description
Martin Renvoize (ashimema)
2018-12-10 11:51:35 UTC
Created attachment 83008 [details] [review] Bug 21980: Add new excpetions for Koha::Account He add two new exceptions here; One to be thrown when negative 'amount' is passed into verious account methods that always expect positive decimals and another to be thrown when a bad 'type' is passed into an account method. This patch was split out from bug 21002 to prevent 21002 from blocking bug 21727. It is a trivial patch adding 2 new exceptions. Created attachment 83046 [details] [review] Bug 21980: Add new excpetions for Koha::Account He add two new exceptions here; One to be thrown when negative 'amount' is passed into verious account methods that always expect positive decimals and another to be thrown when a bad 'type' is passed into an account method. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> This trivial enhancement can skip QA. Created attachment 83085 [details] [review] Bug 21980: Add new excpetions for Koha::Account He add two new exceptions here; One to be thrown when negative 'amount' is passed into verious account methods that always expect positive decimals and another to be thrown when a bad 'type' is passed into an account method. Sponsored-by: PTFS Europe Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Awesome work all! Pushed to master for 19.05 Enhancement, this will not be backported for 18.11.x at the moment. |