Description
Tomás Cohen Arazi
2018-12-12 16:35:50 UTC
Created attachment 83494 [details] [review] Bug 21992: Use ->set_password in onboarding.pl To test, verify the onboarding process sets the password correctly. Created attachment 83495 [details] [review] Bug 21992: Use ->set_password in member-password.pl This patch makes member-password.pl use $patron->set_password instead of update_password. The side effect is that setting password and userid become separate steps in the code. For the password all the initial checks are the same, but password strength is checked on calling set_password and an exception is thrown. So instead of checking the password quality, we just wait for exceptions and behave the same as before. Bonus: you will notice I reused the initially fetched $patron object. Things get simpler :-D To test: - Verify that changing the password / userid for a patron works as usual Created attachment 83496 [details] [review] Bug 21992: Use set_password in memberentry.pl To test: - Verify that changing the password and userid of a patron by globally editing they works, Created attachment 83497 [details] [review] Bug 21992: Remove use of update_password in create_superlibrarian.pl In this case we are not using $patron->set_password, because we want to keep the current behaviour: no checks on the password quality. Created attachment 83498 [details] [review] Bug 21992: Use set_password opac/opac-password-recovery.pl Created attachment 83499 [details] [review] Bug 21992: Remove uses of update_password in tests Created attachment 83500 [details] [review] Bug 21992: Remove unused Koha::Patron->update_password method This patch removes the no longer used method. To test: - Apply this patch - Run: $ git grep update_password => SUCCESS: Only references are in Auth_with_ldap.pm and not related - Sign off :-D Created attachment 83592 [details] [review] Bug 21992: Remove unused Koha::Patron->update_password method This patch removes the no longer used method. To test: - Apply this patch - Run: $ git grep update_password => SUCCESS: Only references are in Auth_with_ldap.pm and not related - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83604 [details] [review] Bug 21992: Remove unused Koha::Patron->update_password method This patch removes the no longer used method. To test: - Apply this patch - Run: $ git grep update_password => SUCCESS: Only references are in Auth_with_ldap.pm and not related - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported at this time to 18.11.x series. |