Summary: | Add pattern parameter in Koha::Token | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | josef.moravec, lucas, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
Preparatory patch for GDPR enhancements that may be forthcoming.
|
Version(s) released in: |
19.05.00, 18.11.05
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 21336 | ||
Attachments: |
Bug 21998: Add pattern parameter in Koha::Token
Bug 21998: Add pattern parameter in Koha::Token Bug 21998: Throw exception on bad pattern Bug 21998: Throw exception on bad pattern Bug 21998: Silent tests Bug 21998: Add pattern parameter in Koha::Token Bug 21998: Throw exception on bad pattern Bug 21998: Silent tests |
Description
Marcel de Rooy
2018-12-14 08:10:09 UTC
Created attachment 83196 [details] [review] Bug 21998: Add pattern parameter in Koha::Token Allow a pattern too in Koha::Token->generate. Only supported length. Does not affect CSRF calls. So tiny change without further impact. Test plan: Run t/Token.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> I am going to add mine bit of work here, stay tuned ;) Created attachment 83347 [details] [review] Bug 21998: Add pattern parameter in Koha::Token Allow a pattern too in Koha::Token->generate. Only supported length. Does not affect CSRF calls. So tiny change without further impact. Test plan: Run t/Token.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 83348 [details] [review] Bug 21998: Throw exception on bad pattern Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 84401 [details] [review] Bug 21998: Throw exception on bad pattern Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Cross sign-offs ;) ok 4 - Only uppercase letters Use of uninitialized value $ch in string ne at /usr/share/perl5/String/Random.pm line 141. ok 5 - Exception should be thrown when wrong pattern is used This warning from String::Random is annoying, but no problem.. Created attachment 85791 [details] [review] Bug 21998: Silent tests (In reply to Jonathan Druart from comment #8) > Created attachment 85791 [details] [review] [review] > Bug 21998: Silent tests Thanks Jonathan Created attachment 86665 [details] [review] Bug 21998: Add pattern parameter in Koha::Token Allow a pattern too in Koha::Token->generate. Only supported length. Does not affect CSRF calls. So tiny change without further impact. Test plan: Run t/Token.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86666 [details] [review] Bug 21998: Throw exception on bad pattern Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86667 [details] [review] Bug 21998: Silent tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Small enhancement with no noticeable effects and no regressions. False positive in the QA scripts about POD missing. Passing QA Awesome work all! Pushed to master for 19.05 As a preparatory enhancement for GDPR work I've chosen to backport this one. Pushed to 18.11.x for 18.11.05 not backporting enhancement to 18.05.x |