|
Description
Jonathan Druart
2018-12-14 19:28:18 UTC
Created attachment 83248 [details] [review] Bug 22007: Remove html filters when KohaDates called with a parameter Bug 13618 took care of the KohaDates output but not if it is called with a parameter (eg. [% var | $KohaDates with_hours => 1 %]). We could avoid unnecessary processing by removing the extra html filter. Patch generated with the following command: % perl -p -i -e 's/KohaDates([^%\|]*)\s?\|\s?html\s?/KohaDates $1/g' **/*.inc **/*.tt Created attachment 83249 [details] [review] Bug 22007: Handle safe filtered output (KohaDates) Created attachment 83250 [details] [review] Bug 22007: Also handle Price and HtmlTags Those 2 filters should return safe output as well Created attachment 83251 [details] [review] Bug 22007: Generated with add_missing_filters.pl Created attachment 83286 [details] [review] Bug 22007: Remove html filters when KohaDates called with a parameter Bug 13618 took care of the KohaDates output but not if it is called with a parameter (eg. [% var | $KohaDates with_hours => 1 %]). We could avoid unnecessary processing by removing the extra html filter. Patch generated with the following command: % perl -p -i -e 's/KohaDates([^%\|]*)\s?\|\s?html\s?/KohaDates $1/g' **/*.inc **/*.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 83287 [details] [review] Bug 22007: Handle safe filtered output (KohaDates) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 83288 [details] [review] Bug 22007: Also handle Price and HtmlTags Those 2 filters should return safe output as well Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 83289 [details] [review] Bug 22007: Generated with add_missing_filters.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 83561 [details] [review] Bug 22007: Remove html filters when KohaDates called with a parameter Bug 13618 took care of the KohaDates output but not if it is called with a parameter (eg. [% var | $KohaDates with_hours => 1 %]). We could avoid unnecessary processing by removing the extra html filter. Patch generated with the following command: % perl -p -i -e 's/KohaDates([^%\|]*)\s?\|\s?html\s?/KohaDates $1/g' **/*.inc **/*.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 83562 [details] [review] Bug 22007: Handle safe filtered output (KohaDates) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 83563 [details] [review] Bug 22007: Also handle Price and HtmlTags Those 2 filters should return safe output as well Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 83564 [details] [review] Bug 22007: Generated with add_missing_filters.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.02 Merge conflicts when attempting to backport to 18.05. If this is required for 18.05.x this will need to be rebased. |