| Summary: | Item status not shown accurately on request.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
| Component: | Hold requests | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, lucas, marjorie.barry-vila, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 |
||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 20708 | ||
| Attachments: |
Bug 22021: Improve item status display when placing holds in staff
Bug 22021: Improve item status display when placing holds in staff Bug 22021: Improve item status display when placing holds in staff |
||
|
Description
Christopher Brannon
2018-12-18 16:52:19 UTC
Still valid. More so: if damaged and lost, only damaged shows. (In reply to Katrin Fischer from comment #1) > Still valid. More so: if damaged and lost, only damaged shows. I do not understand, I see that in the template: 436 [% IF ( itemloo.damaged ) %] 437 <br />Damaged 438 [% END %] I guess we want to displayed the description for the AV DAMAGED. Lost description as well? One above the other? The category isn't needed as much as the description of the authorized value in that category. Created attachment 91519 [details] [review] Bug 22021: Improve item status display when placing holds in staff This patch is a bit of a clean-up to bring the item status display more in line with the display on the detail page: - show descrpition of authorised value for not for loan instead of hardcoded text - Show description of authorised value for lost instead of hardcoded text This is also a translatability fix, as the text came from the .pl - Show description of authorised value damaged instead of hardcoded text - Make sequence of status match display on details page: lost - damaged - not for loan To test: - On a record with multiple items - Add different status to the items damaged, lost, not for loan - Make sure you have items with one status and multiple status at the same time - Look at how the status display on the detail page - Place a hold, compare display - Apply patch - Repeat Created attachment 91536 [details] [review] Bug 22021: Improve item status display when placing holds in staff This patch is a bit of a clean-up to bring the item status display more in line with the display on the detail page: - show descrpition of authorised value for not for loan instead of hardcoded text - Show description of authorised value for lost instead of hardcoded text This is also a translatability fix, as the text came from the .pl - Show description of authorised value damaged instead of hardcoded text - Make sequence of status match display on details page: lost - damaged - not for loan To test: - On a record with multiple items - Add different status to the items damaged, lost, not for loan - Make sure you have items with one status and multiple status at the same time - Look at how the status display on the detail page - Place a hold, compare display - Apply patch - Repeat Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 91631 [details] [review] Bug 22021: Improve item status display when placing holds in staff This patch is a bit of a clean-up to bring the item status display more in line with the display on the detail page: - show descrpition of authorised value for not for loan instead of hardcoded text - Show description of authorised value for lost instead of hardcoded text This is also a translatability fix, as the text came from the .pl - Show description of authorised value damaged instead of hardcoded text - Make sequence of status match display on details page: lost - damaged - not for loan To test: - On a record with multiple items - Add different status to the items damaged, lost, not for loan - Make sure you have items with one status and multiple status at the same time - Look at how the status display on the detail page - Place a hold, compare display - Apply patch - Repeat Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |