Summary: | Simplify C4::Matcher->get_matches | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | dcook, m.de.rooy, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 24348 | ||
Attachments: |
Bug 22046: Simplify and unify the code for get_matches
Bug 22046: Simplify and unify the code for get_matches Bug 22046: Simplify and unify the code for get_matches |
Description
Nick Clemens (kidclamp)
2018-12-24 12:52:44 UTC
Created attachment 83475 [details] [review] Bug 22046: Simplify and unify the code for get_matches To test: 1 - Stage some records for import 2 - Manage the records 3 - Use several different matching rules and note the results 4 - Apply patch 5 - Try several matching rules again and note the results have not changed 6 - Try under both search engines (Zebra and ES) I haven't looked at the patch but might be worth keeping in mind https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710. (In reply to David Cook from comment #2) > I haven't looked at the patch but might be worth keeping in mind > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710. I don't think it should have any effect here - this simply removes a conditional on SearchEngine setting so that the matcher code is the same in either scenario (the check does still happen, but in a subroutine, this removes a second check) Created attachment 89058 [details] [review] Bug 22046: Simplify and unify the code for get_matches To test: 1 - Stage some records for import 2 - Manage the records 3 - Use several different matching rules and note the results 4 - Apply patch 5 - Try several matching rules again and note the results have not changed 6 - Try under both search engines (Zebra and ES) Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 90017 [details] [review] Bug 22046: Simplify and unify the code for get_matches To test: 1 - Stage some records for import 2 - Manage the records 3 - Use several different matching rules and note the results 4 - Apply patch 5 - Try several matching rules again and note the results have not changed 6 - Try under both search engines (Zebra and ES) Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Code looks good to me. Tests would be even more convincing ;) Awesome work all! Pushed to master for 19.05 I'm not going to backport this architectural enhancement to 18.11.x series at this time. |