Summary: | UNIMARC default XSLT broken by Bug 14716 | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | OPAC | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Julian Maurice <julian.maurice> |
Severity: | critical | ||
Priority: | P5 - low | CC: | dubyk, jesse, julian.maurice, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 14716 | ||
Bug Blocks: | |||
Attachments: |
Bug 22085: fix UNIMARC default XSLT broken by Bug 14716
Bug 22085: fix UNIMARC default XSLT broken by Bug 14716 Bug 22085: fix UNIMARC default XSLT broken by Bug 14716 |
Description
Fridolin Somers
2019-01-09 12:17:22 UTC
Created attachment 83754 [details] [review] Bug 22085: fix UNIMARC default XSLT broken by Bug 14716 Bug 14716 added a call to encode-uri() and namespace str. This namespace declaration is sometimes missing in UNIMARC default XSLT files. This patch adds namespace declaration also where encode-uri is not used because it may be used in the future. And those files are the base for home made custom files. Test plan : 1) Use a UNIMARC DB 2) Use default in all XSLT sysprefs 3) Apply patch 4) Perform a search on OPAC 5) Check display is OK 6) Click on a record for detail page 7) Check display is OK 8) Perform a search on staff interface 9) Check display is OK 10) Click on a record for detail page 11) Check display is OK Created attachment 83862 [details] [review] Bug 22085: fix UNIMARC default XSLT broken by Bug 14716 Bug 14716 added a call to encode-uri() and namespace str. This namespace declaration is sometimes missing in UNIMARC default XSLT files. This patch adds namespace declaration also where encode-uri is not used because it may be used in the future. And those files are the base for home made custom files. Test plan : 1) Use a UNIMARC DB 2) Use default in all XSLT sysprefs 3) Apply patch 4) Perform a search on OPAC 5) Check display is OK 6) Click on a record for detail page 7) Check display is OK 8) Perform a search on staff interface 9) Check display is OK 10) Click on a record for detail page 11) Check display is OK Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 84192 [details] [review] Bug 22085: fix UNIMARC default XSLT broken by Bug 14716 Bug 14716 added a call to encode-uri() and namespace str. This namespace declaration is sometimes missing in UNIMARC default XSLT files. This patch adds namespace declaration also where encode-uri is not used because it may be used in the future. And those files are the base for home made custom files. Test plan : 1) Use a UNIMARC DB 2) Use default in all XSLT sysprefs 3) Apply patch 4) Perform a search on OPAC 5) Check display is OK 6) Click on a record for detail page 7) Check display is OK 8) Perform a search on staff interface 9) Check display is OK 10) Click on a record for detail page 11) Check display is OK Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.03 Pushed to 18.05.x for 18.05.09 |