Summary: | Markup fixes for OPAC article request page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 22102: Markup fixes for OPAC article request page
Bug 22102: Markup fixes for OPAC article request page Bug 22102: Markup fixes for OPAC article request page Bug 22102: Markup fixes for OPAC article request page |
Description
Owen Leonard
2019-01-11 15:13:56 UTC
Created attachment 83802 [details] [review] Bug 22102: Markup fixes for OPAC article request page This patch makes a few improvements to the OPAC article request page: - Improve the breadcrumbs menu by adding a link to the title - Add a header with the record's title - Wrap the "no article requests" message in the correct dialog div - Remove obsolete CDATA marker To test, apply the patch and log in to the OPAC - Peform a search which will return multiple results - Click "Request article" on a title for which article requests can be submitted. - Confirm that the breadcrumbs menu looks and works correctly. - Click "Request article" on a title for which article requsts are not allowed. - Confirm that the message is correctly styled. Failed to apply patch Bug 22102 - Markup fixes for OPAC article request page 83802 - Bug 22102: Markup fixes for OPAC article request page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22102: Markup fixes for OPAC article request page fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt). error: could not build fake ancestor Patch failed at 0001 Bug 22102: Markup fixes for OPAC article request page The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22102-Markup-fixes-for-OPAC-article-request-pa-j8mImP.patch Created attachment 83888 [details] [review] Bug 22102: Markup fixes for OPAC article request page This patch makes a few improvements to the OPAC article request page: - Improve the breadcrumbs menu by adding a link to the title - Add a header with the record's title - Wrap the "no article requests" message in the correct dialog div - Remove obsolete CDATA marker To test, apply the patch and log in to the OPAC - Peform a search which will return multiple results - Click "Request article" on a title for which article requests can be submitted. - Confirm that the breadcrumbs menu looks and works correctly. - Click "Request article" on a title for which article requsts are not allowed. - Confirm that the message is correctly styled. Created attachment 84227 [details] [review] Bug 22102: Markup fixes for OPAC article request page This patch makes a few improvements to the OPAC article request page: - Improve the breadcrumbs menu by adding a link to the title - Add a header with the record's title - Wrap the "no article requests" message in the correct dialog div - Remove obsolete CDATA marker To test, apply the patch and log in to the OPAC - Peform a search which will return multiple results - Click "Request article" on a title for which article requests can be submitted. - Confirm that the breadcrumbs menu looks and works correctly. - Click "Request article" on a title for which article requsts are not allowed. - Confirm that the message is correctly styled. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 84236 [details] [review] Bug 22102: Markup fixes for OPAC article request page This patch makes a few improvements to the OPAC article request page: - Improve the breadcrumbs menu by adding a link to the title - Add a header with the record's title - Wrap the "no article requests" message in the correct dialog div - Remove obsolete CDATA marker To test, apply the patch and log in to the OPAC - Peform a search which will return multiple results - Click "Request article" on a title for which article requests can be submitted. - Confirm that the breadcrumbs menu looks and works correctly. - Click "Request article" on a title for which article requsts are not allowed. - Confirm that the message is correctly styled. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series. |