Summary: | Clean up patron API keys template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, hickeyhe, jke0429, josef.moravec, martin.renvoize, nick, testopia |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/members/apikeys.pl | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 20654 | ||
Attachments: |
Bug 22104: Clean up patron API keys template
API Keys page Bug 22104: Clean up patron API keys template Screenshot showing when no keys have been added Screenshot showing an added key Bug 22104: Clean up patron API keys template Bug 22104: Clean up patron API keys template |
Description
Owen Leonard
2019-01-11 17:05:57 UTC
Created attachment 83815 [details] [review] Bug 22104: Clean up patron API keys template This patch makes two corrections to the patron API key template: Convert to Bootstrap grid and correct class on "new key" button. To test, apply the patch and enable the RESTOAuth2ClientCredentials preference. - Open a patron record in the staff client and choose More -> Manage API keys. - On the API keys page, confirm that the page adjusts well at various page widths. - Confirm that the size of the "Generate new client id/key pair" button matches the buttons in the toolbar. Created attachment 84159 [details]
API Keys page
API keys page after apply the patch
I did not observe any changes and the ' Generate a new client id/secret pair' did not become a button other then adjusting more at different page sizes. Created attachment 84160 [details] [review] Bug 22104: Clean up patron API keys template This patch makes two corrections to the patron API key template: Convert to Bootstrap grid and correct class on "new key" button. To test, apply the patch and enable the RESTOAuth2ClientCredentials preference. - Open a patron record in the staff client and choose More -> Manage API keys. - On the API keys page, confirm that the page adjusts well at various page widths. - Confirm that the size of the "Generate new client id/key pair" button matches the buttons in the toolbar. Signed-off-by: Jack Kelliher <jke0429@stacmail.net> Accidental Signoff Created attachment 84172 [details]
Screenshot showing when no keys have been added
Created attachment 84173 [details]
Screenshot showing an added key
Would anyone be willing to take another look at this? My testing matches your screenshots in comment #6 and #7. However, there is some inconsistency in how the different account screens display. I can post some screenshots if you would like. When you narrow the screen width down most of the account screens leave the account information on the top left (name, address, etc), the menu items under this (Check out, Details, etc), and then content for the screen to the right. Th API key screen along with the Holds history and Modification log behave in a more responsive manner. These have the particular screen first, the account information, then the menu items. If this is what you intended (the results matching your screenshots) then I am happy to sign-off on that basis. Created attachment 84232 [details] [review] Bug 22104: Clean up patron API keys template This patch makes two corrections to the patron API key template: Convert to Bootstrap grid and correct class on "new key" button. To test, apply the patch and enable the RESTOAuth2ClientCredentials preference. - Open a patron record in the staff client and choose More -> Manage API keys. - On the API keys page, confirm that the page adjusts well at various page widths. - Confirm that the size of the "Generate new client id/key pair" button matches the buttons in the toolbar. Signed-off-by: David Nind <david@davidnind.com> Created attachment 84234 [details] [review] Bug 22104: Clean up patron API keys template This patch makes two corrections to the patron API key template: Convert to Bootstrap grid and correct class on "new key" button. To test, apply the patch and enable the RESTOAuth2ClientCredentials preference. - Open a patron record in the staff client and choose More -> Manage API keys. - On the API keys page, confirm that the page adjusts well at various page widths. - Confirm that the size of the "Generate new client id/key pair" button matches the buttons in the toolbar. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Enhancement will not be backported to 18.11.x |