Bug 22107

Summary: Avoid deleting data in some tests
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: Test SuiteAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact: Nick Clemens <nick>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, jesse, martin.renvoize, nick
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 22107: Make tests use a simpler class, with no FK
Bug 22107: patrons.t doesn't need to delete existing data
Bug 22107: Make tests use a simpler class, with no FK
Bug 22107: patrons.t doesn't need to delete existing data

Description Tomás Cohen Arazi 2019-01-11 18:10:49 UTC
The following tests rely on deleting all patrons for running, and this is failing (and doesn't make sense):

t/db_dependent/api/v1/patrons.t
t/db_dependent/Koha/REST/Plugin/Objects.t
Comment 1 Tomás Cohen Arazi 2019-01-11 18:16:51 UTC
Created attachment 83816 [details] [review]
Bug 22107: Make tests use a simpler class, with no FK

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Tomás Cohen Arazi 2019-01-11 18:16:54 UTC
Created attachment 83817 [details] [review]
Bug 22107: patrons.t doesn't need to delete existing data

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Nick Clemens 2019-01-11 18:50:24 UTC
Created attachment 83819 [details] [review]
Bug 22107: Make tests use a simpler class, with no FK

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens 2019-01-11 18:50:27 UTC
Created attachment 83820 [details] [review]
Bug 22107: patrons.t doesn't need to delete existing data

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Nick Clemens 2019-01-11 18:51:52 UTC
Thanks Tomas, pushed to master for 19.05
Comment 6 Martin Renvoize 2019-01-14 14:30:25 UTC
Pushed to 18.11.x for 18.11.02
Comment 7 Jesse Maseto 2019-01-23 19:24:24 UTC
Pushed to 18.05.x for 18.05.09
Comment 8 Fridolin Somers 2019-01-30 08:07:44 UTC
Tests impacted are not in 17.11.x