|
Description
Katrin Fischer
2019-01-13 11:02:01 UTC
Created attachment 83841 [details] [review] Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat pref To test: - Install BLDSS backend see: https://wiki.koha-community.org/wiki/ILL_backends - Add a new BLDSS ILL request - Edit ILL request - Fill in Price paid field - Verify Price paid is formatted correctly on 'Manage ILL request' page Created attachment 83931 [details] [review] Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat pref To test: - Install BLDSS backend see: https://wiki.koha-community.org/wiki/ILL_backends - Add a new BLDSS ILL request - Edit ILL request - Fill in Price paid field - Verify Price paid is formatted correctly on 'Manage ILL request' page Signed-off-by: Ethan Amohia <ethan.amohia@gmail.com> Thx, Ethan! Created attachment 84884 [details] [review] Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat pref To test: - Install BLDSS backend see: https://wiki.koha-community.org/wiki/ILL_backends - Add a new BLDSS ILL request - Edit ILL request - Fill in Price paid field - Verify Price paid is formatted correctly on 'Manage ILL request' page Signed-off-by: Ethan Amohia <ethan.amohia@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Another good catch. Passing QA Awesome work all! Pushed to master for 19.05 Created attachment 87386 [details] [review] Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat pref To test: - Install BLDSS backend see: https://wiki.koha-community.org/wiki/ILL_backends - Add a new BLDSS ILL request - Edit ILL request - Fill in Price paid field - Verify Price paid is formatted correctly on 'Manage ILL request' page Signed-off-by: Ethan Amohia <ethan.amohia@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Tiny rebase, moving back into Nick's queue. Created attachment 87450 [details] [review] Display 'Price paid' on ILL requests according to CurrencyFormat pref To test: - Install BLDSS backend see: https://wiki.koha-community.org/wiki/ILL_backends - Add a new BLDSS ILL request - Edit ILL request - Fill in Price paid field - Verify Price paid is formatted correctly on 'Manage ILL request' page Signed-off-by: Ethan Amohia <ethan.amohia@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87451 [details] [review] Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat pref To test: - Install BLDSS backend see: https://wiki.koha-community.org/wiki/ILL_backends - Add a new BLDSS ILL request - Edit ILL request - Fill in Price paid field - Verify Price paid is formatted correctly on 'Manage ILL request' page Signed-off-by: Ethan Amohia <ethan.amohia@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Hi Andrew, did you mean to add a sign-off? No, on Martin's request, I just rebased it and made sure it was up to date with the current state of master. Awesome work all! Pushed to master for 19.05 Re-implimentation pushed to 18.11.x for 18.11.05 missing dependency for 18.05.x |