| Summary: | Update cataloguing plugin system to not generate type parameter in script tag | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
| Component: | Architecture, internals, and plumbing | Assignee: | Josef Moravec <josef.moravec> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers, jesse, martin.renvoize, nick, oleonard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 22126 | ||
| Attachments: |
Bug 22124: Update cataloguing plugin system to not generate type parameter in script tag
Bug 22124: Update cataloguing plugin system to not generate type parameter in script tag Bug 22124: Update cataloguing plugin system to not generate type parameter in script tag |
||
|
Description
Josef Moravec
2019-01-14 09:16:36 UTC
Created attachment 83884 [details] [review] Bug 22124: Update cataloguing plugin system to not generate type parameter in script tag Test plan: 1) Apply the patch 2) Have defined some cataloguing plugin which generates javascript - for example dateaccessioned.pl 3) Go to cataloguing/adding item and show source -> there should be no type parameter in script tag in code added by cataloguing pulgin 4) prove t/db_dependent/FrameworkPlugin.t Created attachment 83886 [details] [review] Bug 22124: Update cataloguing plugin system to not generate type parameter in script tag Test plan: 1) Apply the patch 2) Have defined some cataloguing plugin which generates javascript - for example dateaccessioned.pl 3) Go to cataloguing/adding item and show source -> there should be no type parameter in script tag in code added by cataloguing pulgin 4) prove t/db_dependent/FrameworkPlugin.t Signed-off-by: Owen Leonard <oleonard@myacpl.org> > Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Thanks Owen!
Created attachment 84243 [details] [review] Bug 22124: Update cataloguing plugin system to not generate type parameter in script tag Test plan: 1) Apply the patch 2) Have defined some cataloguing plugin which generates javascript - for example dateaccessioned.pl 3) Go to cataloguing/adding item and show source -> there should be no type parameter in script tag in code added by cataloguing pulgin 4) prove t/db_dependent/FrameworkPlugin.t Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.03 Pushed to 18.05.x for 18.05.09 Trivial, I dont push to 17.11.x |