Summary: | Wrong layout in OAI-PMH:archiveID syspref description | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Templates | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | dcook, josef.moravec, katrin.fischer |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21926 | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description
Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description |
Description
Tomás Cohen Arazi
2019-01-15 11:26:02 UTC
Created attachment 83950 [details] [review] Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description This patch fixes a trivial text layout problem on the syspref description. To test: - Search for the OAI-PMH:archiveID syspref on the staff interface => FAIL: Notice the colon is placed *after* the input, and looks weird. - Apply this patch - Reload the page => SUCCESS: The colon is placed *before* the input, and looks more correct. - Sign off :-D Created attachment 83996 [details] [review] Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description This patch fixes a trivial text layout problem on the syspref description. To test: - Search for the OAI-PMH:archiveID syspref on the staff interface => FAIL: Notice the colon is placed *after* the input, and looks weird. - Apply this patch - Reload the page => SUCCESS: The colon is placed *before* the input, and looks more correct. - Sign off :-D Signed-off-by: Devinim <kohadevinim@devinim.com.tr> I think the colon might be after the OAI-PMH:archiveID to show that they don't need to include the colon in the value itself? I've been wondering if it's worth adding the following to the description: http://www.openarchives.org/OAI/openarchivesprotocol.html#UniqueIdentifier http://www.openarchives.org/OAI/2.0/guidelines-oai-identifier.htm I suppose if people are interested in OAI-PMH, they should look it up themselves, but I know it's taken me years to read these documents inside and out. Maybe we could add something like "E.g. <OAI-PMH:archiveID>:<biblionumber>" to make it more obvious about how the identifier is constructed using this system preference?" I agree with David in that I understand the : as a hint to not enter it. Tomas, could you take a look at comment 3 and comment please? |