| Summary: | Fields of ACCTDETAILS not working properly | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Muneeb Kalathil <muneebkalathil> |
| Component: | Notices | Assignee: | Muneeb Kalathil <muneebkalathil> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | major | ||
| Priority: | P2 | CC: | barton, kris.sinnaeve, lisettepalouse+koha, lucas, martin.renvoize, mkstephens, nick, wizzyrea |
| Version: | 18.11 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.05
|
|
| Circulation function: | |||
| Attachments: |
Patch file to fix this bug.
Bug 22139: Fields of ACCTDETAILS email not populating Bug 22139: Fields of ACCTDETAILS email not populating Bug 22139: Fields of ACCTDETAILS email not populating |
||
|
Description
Muneeb Kalathil
2019-01-16 05:29:52 UTC
> #####################################
>
> * Checkout notice is working fine with ACCTDETAILS details.
> * Also I imported this DB to 18.05 and it is working perfectly; No issues .
> * Didn't find any errors in log related to this.
Do you mean it's a regression from 18.05 to 18.11?
Can confirm; we just had a partner upgrade from 18.05 to 18.11. Was working in 18.05, is not working now. We are said partner. As a workaround, we're planning to rewrite the notice so that it is more generic and doesn't use the remaining fields from the borrowers table. It is odd, however, that the notice does pass through borrowers.password but not the others. Thanks for taking a look at this! (In reply to Katrin Fischer from comment #1) > > ##################################### > > > > * Checkout notice is working fine with ACCTDETAILS details. > > * Also I imported this DB to 18.05 and it is working perfectly; No issues . > > * Didn't find any errors in log related to this. > > Do you mean it's a regression from 18.05 to 18.11? New Installation on 18.11 - Not working DB from 18.11 to 18.05 - Its working We are also having this issue. We are using TT syntax in this notice and it was working yesterday but not today for borrower information. It does work still for branch information. We updated to 18.11.03 overnight. Lisette Created attachment 88207 [details] [review] Patch file to fix this bug. This bug is indeed introduced between Koha 18.05 and Koha 18.11 when moving AddMember and ModMember from Members to Patron.
I expect it's fixed by adding the following line after storing the new patron:
$newdata{'borrowernumber'} = $borrowernumber;
Created attachment 88216 [details] [review] Bug 22139: Fields of ACCTDETAILS email not populating To test: * Make sure AutoEmailOpacUser is set to "send" * Create a new patron with a username and password, and an email address * In Kohadevbox, check the mail (usually you can type "mail" and go down to the last message) - these do not go into the message queue and they are processed immediately. notice that the email does not have <<borrowers.title>> <<borrowers.firstname>> <<borrowers.surname>> Apply this patch, restart the things, retest as above. Formatting patch for community guidelines, authorship retained by Kris. Created attachment 88245 [details] [review] Bug 22139: Fields of ACCTDETAILS email not populating To test: * Make sure AutoEmailOpacUser is set to "send" * Create a new patron with a username and password, and an email address * In Kohadevbox, check the mail (usually you can type "mail" and go down to the last message) - these do not go into the message queue and they are processed immediately. notice that the email does not have <<borrowers.title>> <<borrowers.firstname>> <<borrowers.surname>> Apply this patch, restart the things, retest as above. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 88257 [details] [review] Bug 22139: Fields of ACCTDETAILS email not populating To test: * Make sure AutoEmailOpacUser is set to "send" * Create a new patron with a username and password, and an email address * In Kohadevbox, check the mail (usually you can type "mail" and go down to the last message) - these do not go into the message queue and they are processed immediately. notice that the email does not have <<borrowers.title>> <<borrowers.firstname>> <<borrowers.surname>> Apply this patch, restart the things, retest as above. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Perfect fix, thankyou very much for fixing it before I got down to it in my todo list :) Passing QA and welcome to the team :). For me it was a show stopper to migrate from Koha 3.20 to Koha 18.11. It took me some time to find the root cause. A diff between the Koha 18.05 version of memberentry.pl and the Koha 18.11 version of memberentry.pl pointed me into the right direction. Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 not backporting to 18.05.x not backporting to 18.05.x Comment on attachment 88207 [details] [review] Patch file to fix this bug. Review of attachment 88207 [details] [review]: ----------------------------------------------------------------- Thanks this patch is working fine |