Summary: | An item's current location changes to blank when it is removed from Course Reserves | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Course reserves | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | 1joynelson, costalc, fridolin.somers, jonathan.druart, jzairo, kyle, lucas, marjorie.barry-vila, martin.renvoize, nick, patrick.robitaille, severine.queune, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03
|
|
Circulation function: | |||
Bug Depends on: | 10382 | ||
Bug Blocks: | |||
Attachments: |
Bug 22142: Highlight the issue
Bug 22142: Do not revert data if 'unchanged' was set Bug 22142: Highlight the issue Bug 22142: Do not revert data if 'unchanged' was set Bug 22142: Highlight the issue Bug 22142: Do not revert data if 'unchanged' was set |
Description
Kelly McElligott
2019-01-16 14:55:16 UTC
I've got a slightly different problem on 18.05.00 (and on the demo Koha of Biblibre 18.05.06.000 and 18.11.03.000) : on step 5, after removing an item of a course reserve, all fields modified in the course reserve are applied, and none of of the original values are kept. This is confirmed on master: Add an item to a course (active or inactive) change no fields, remove it from the course, itemtype, location and collection are cleared Add it again, this time changing all the fields, then remove it. Those fields are all set! Created attachment 90577 [details] [review] Bug 22142: Highlight the issue *** Bug 22984 has been marked as a duplicate of this bug. *** We are losing data here... any chance for a fix? Created attachment 92015 [details] [review] Bug 22142: Do not revert data if 'unchanged' was set Here is a quick try, tests are passing so it should fix the reported issues. Created attachment 92152 [details] [review] Bug 22142: Highlight the issue Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 92153 [details] [review] Bug 22142: Do not revert data if 'unchanged' was set Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 92168 [details] [review] Bug 22142: Highlight the issue Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 92169 [details] [review] Bug 22142: Do not revert data if 'unchanged' was set Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Really glad to see this one resolved! Nice work! Pushed to master for 19.11.00 Any chance to backport this to 19.05/18.11? Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |