Bug 22147

Summary:	Hide 'Batch modify' button when printing reports
Product:	Koha	Reporter:	Aleisha Amohia <aleisha>
Component:	Reports	Assignee:	Jasmine Amohia <jasmineamohia.student>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers, jasmineamohia.student, lucas, martin.renvoize, nick
Version:	unspecified	Keywords:	Academy
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22152
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 22147: Hidden 'Batch modify' button on report print layout Bug 22147: Hidden 'Batch modify' button on report print layout Bug 22147: Hidden 'Batch modify' button on report print layout

Description Aleisha Amohia 2019-01-16 21:04:30 UTC

To reproduce: 
1) Create or run a report that has an itemnumber column
2) Notice the Batch modify button under the itemnumber heading
3) Print the page 
4) Notice the button still shows on the printed page

Comment 1 Jasmine Amohia 2019-01-16 21:32:23 UTC

Created attachment 84097 [details] [review]
Bug 22147: Hidden 'Batch modify' button on report print layout

Test plan:
1) Create or run a report that has an itemnumber column
2) Notice the Batch modify button under the itemnumber heading
3) Print the page
4) Notice the button no longer shows on the printed page

Comment 2 Katrin Fischer 2019-01-17 06:42:20 UTC

Created attachment 84127 [details] [review]
Bug 22147: Hidden 'Batch modify' button on report print layout

Test plan:
1) Create or run a report that has an itemnumber column
2) Notice the Batch modify button under the itemnumber heading
3) Print the page
4) Notice the button no longer shows on the printed page

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 3 Martin Renvoize (ashimema) 2019-02-08 14:17:53 UTC

Created attachment 84866 [details] [review]
Bug 22147: Hidden 'Batch modify' button on report print layout

Test plan:
1) Create or run a report that has an itemnumber column
2) Notice the Batch modify button under the itemnumber heading
3) Print the page
4) Notice the button no longer shows on the printed page

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 4 Martin Renvoize (ashimema) 2019-02-08 14:18:16 UTC

No regressions found, sane and sensible change.

Passing QA

Comment 5 Nick Clemens (kidclamp) 2019-02-19 14:33:07 UTC

Awesome work all!

Pushed to master for 19.05

Comment 6 Martin Renvoize (ashimema) 2019-02-26 09:00:32 UTC

Pushed to 18.11.x for 18.11.04

Comment 7 Lucas Gass (lukeg) 2019-03-06 21:44:46 UTC

backported to 18.05.x for 18.05.11